Fix several build issues if built with -DDYNAREC=Off #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goshhhy
changed the title
goshhhy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Summary
cyrix_load_seg_descriptor() touches codegen_flat_ds and codegen_flat_ss even if dynarec is disabled.
386_dynarec_ops.c is built even if dynarec is disabled, references many things, and is not needed in that configuration.
dma_page_write() calls update_tsc(), and while this isn't called if dynarec is disabled in software, the call is still built in if built with dynarec disabled.
pc_hard_reset_init() sets cycles_main, which only exists if build with dynarec.
these prevent the codebase from building if built with -DDYNAREC=Off.
this pull request fixes all of these.
Checklist
References