Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve Finnish translation #2198

Merged
merged 2 commits into from Mar 8, 2022
Merged

improve Finnish translation #2198

merged 2 commits into from Mar 8, 2022

Conversation

Copy link
Contributor

@ziplantil ziplantil commented Mar 6, 2022

This is an improvement for the 86Box Finnish translation (both Win32 and Qt). I tried to synchronize the changes between the two, although I might've missed some.

Something I noticed is that there are more Win32 strings than Qt ones. For example, the Win32 version has separate strings for tape drives, cartridges, floppies etc. but there's only one set of strings for Qt. For the latter, the first matches had been picked, which meant that the Qt translation used the tape drive strings for all media. That sounded odd, because floppy drive "eject" translated to "remove from cassette tray". I tried to change the Qt translation to be fairly media-agnostic.

@ts-korhonen
Copy link
Contributor

@ts-korhonen ts-korhonen commented Mar 6, 2022

For example, the Win32 version has separate strings for tape drives, cartridges, floppies etc. but there's only one set of strings for Qt.

Qt-port is still relatively new and the translations are automatically generated from Win32, disambiguation is a feature that might be implemented on Qt too.
On that note we still haven't manually edited .po files as you've done. This would make synchronizing them more difficult and need's some discussion among the developers.

src/qt/languages/fi-FI.po Outdated Show resolved Hide resolved
src/qt/languages/fi-FI.po Outdated Show resolved Hide resolved
src/qt/languages/fi-FI.po Outdated Show resolved Hide resolved
src/qt/languages/fi-FI.po Outdated Show resolved Hide resolved
@ziplantil
Copy link
Contributor Author

@ziplantil ziplantil commented Mar 6, 2022

disambiguation is a feature that might be implemented on Qt too.

I could look into this - I have experience working with gettext, which is what .po files are for. It'd probably have to be a separate PR, though...

On that note we still haven't manually edited .po files as you've done. This would make synchronizing them more difficult and need's some discussion among the developers.

I'll try to get the .po file to automatically generate from the .rc for the new changes.

@ts-korhonen
Copy link
Contributor

@ts-korhonen ts-korhonen commented Mar 6, 2022

I'll try to get the .po file to automatically generate from the .rc for the new changes.

No need, this is fine. It's probably best to wait a bit because Qt will become the default UI on Windows too, maybe already in the next release. So this .rc / .po split needs to be solved soon anyways.

@OBattler OBattler merged commit 247d5a7 into 86Box:master Mar 8, 2022
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants