Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBM 386SLC/486SLC/486 Blue Lightning emulation #502

Merged
merged 12 commits into from Dec 21, 2019
Merged

IBM 386SLC/486SLC/486 Blue Lightning emulation #502

merged 12 commits into from Dec 21, 2019

Conversation

Copy link
Contributor

@nerd73 nerd73 commented Dec 16, 2019

This pull request adds preliminary emulation of the IBM SLC and Blue Lightning CPUs to various 286 and 386 PS/2 machines.

@darkstar
Copy link

@darkstar darkstar commented Dec 17, 2019

the indenting looks horrible on this. Granted, some of this is because the original source already mixes tabs and spaces, but three different indentings (1 tab vs. 2 tabs vs. 8 spaces) in 3 consecutive lines? ;-)
719534c#diff-ab781aca9f2f3f40226effc08a525b77R263

@nerd73
Copy link
Contributor Author

@nerd73 nerd73 commented Dec 18, 2019

Thanks. I've done some indenting fixes and cleaned up the CPU tables a bit. The indenting seemed alright in Notepad++, but I guess GitHub uses a different tab length.

@ghost
Copy link

@ghost ghost commented Dec 18, 2019

Lenghts in the 86Box code are a mess in general. A mixture of spaces and tabs. So it's fine at least for me.

@dhrdlicka
Copy link
Contributor

@dhrdlicka dhrdlicka commented Dec 18, 2019

The indenting in 86Box is 4 spaces for first level, 1 tab for second level, 2 tabs for third level and so on.

It might not hurt to agree on using something more consistent though.

@nerd73 is there any reason in particular why you commit the changes through the GitHub web interface and not via a local Git client?

@OBattler
Copy link
Collaborator

@OBattler OBattler commented Dec 21, 2019

It might not hurt to agree on using something more consistent though.

I absolutely agree.

@OBattler OBattler merged commit b9ececc into 86Box:master Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants