[config] Return first writeable backend that isn't worktree by default#32
Merged
Conversation
cmbartschat
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added support from worktree config here #31
The original behavior (before that PR) was to return the first writeable backend, which was the repo level config.
The PR change this to return the last, which is the user's global git config
~/.gitconfigwhen an existing key does not exist.This caused us to populate that global config file erroneously. This PR restores the original behavior while still returning the first backend to contain the key (and avoid returning the worktree config eagerly).
With this change, I am able to clone multiple repos (which before failed due to
originentry being written to the global config file).