Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unauthorized access to download database backup files #48

Closed
rank0 opened this issue Apr 7, 2019 · 3 comments
Closed

Unauthorized access to download database backup files #48

rank0 opened this issue Apr 7, 2019 · 3 comments

Comments

@rank0
Copy link

rank0 commented Apr 7, 2019 •
edited
Loading

1、There is a vulnerability with the permission check。If admin account is logged in, other unauthorized users can download the database backup file directly。The getuser() function always gets the value

PluginHandler.java
101

AdminTokenThreadLocal.java
102

ThreadLocal.java
103

step

2-1

2-1
@94fzb
Copy link
Owner

94fzb commented Apr 9, 2019 •
edited
Loading

This must need admin login state, Please logout and retry
image
This token parse from http request cookie header.
image

No token in cookie, will do 302

image

@rank0
Copy link
Author

rank0 commented Apr 9, 2019

1、First use chrome browser and go to http://118.24.153.47/admin/index#plugin
T2
2、Next use other browser and go to http://118.24.153.47/admin/plugins/backup-sql-file/exportSqlFile
I use firefox ,the request of get is not need cookie
T1

@94fzb
Copy link
Owner

94fzb commented Apr 9, 2019

Thanks, Bug. high level. forget remove token from Threadlocal

@94fzb 94fzb closed this as completed in 5163148 Apr 14, 2019
94fzb added a commit that referenced this issue Apr 22, 2019
@94fzb
Fix #48 forget remove token from ThreadLocal
37b4ddf
94fzb added a commit that referenced this issue Apr 22, 2019
@94fzb
Fix #48 forget remove token from ThreadLocal
2103d2b
94fzb added a commit that referenced this issue Apr 22, 2019
@94fzb
Fix #48 forget remove token from ThreadLocal
5ff060b
94fzb added a commit that referenced this issue Apr 22, 2019
@94fzb
Fix #48 forget remove token from ThreadLocal
387b361
94fzb added a commit that referenced this issue Apr 22, 2019
@94fzb
Fix #48 forget remove token from ThreadLocal
b2b4415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@94fzb @rank0