New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loop support #3

Merged
merged 3 commits into from Nov 21, 2015

Conversation

Projects
None yet
2 participants
@fosspill
Contributor

fosspill commented Nov 6, 2015

Added support for looping! 馃憤

@fosspill

This comment has been minimized.

Show comment
Hide comment
@fosspill

fosspill Nov 6, 2015

Contributor

Slightly "spammy" when it loops:

=========================================================================
Opening audio decoder: [ffmpeg] FFmpeg/libavcodec audio decoders
AUDIO: 48000 Hz, 2 ch, floatle, 0.0 kbit/0.00% (ratio: 0->384000)
Selected audio codec: [ffopus] afm: ffmpeg (FFmpeg opus)
==========================================================================
AO: [alsa] 48000Hz 2ch floatle (4 bytes per sample)
Video: no video
Position: 100 %
A: 207.3 (03:27.2) of 207.3 (03:27.3)  0.0% 


Playing /home/oleerik/Music/yplayer/Free.mp3 (The Pirate Bay Song).mp3.
libavformat file format detected.
[lavf] stream 0: audio (opus), -aid 0, -alang eng
Clip info:
 encoder: google

==========================================================================
Opening audio decoder: [ffmpeg] FFmpeg/libavcodec audio decoders
AUDIO: 48000 Hz, 2 ch, floatle, 0.0 kbit/0.00% (ratio: 0->384000)
Selected audio codec: [ffopus] afm: ffmpeg (FFmpeg opus)
==========================================================================
AO: [alsa] 48000Hz 2ch floatle (4 bytes per sample)
Video: no video
Starting playback...
A:  52.5 (52.4) of 207.3 (03:27.3)  1.2% 

No idea what to do about that. Not too bad anyways!

Contributor

fosspill commented Nov 6, 2015

Slightly "spammy" when it loops:

=========================================================================
Opening audio decoder: [ffmpeg] FFmpeg/libavcodec audio decoders
AUDIO: 48000 Hz, 2 ch, floatle, 0.0 kbit/0.00% (ratio: 0->384000)
Selected audio codec: [ffopus] afm: ffmpeg (FFmpeg opus)
==========================================================================
AO: [alsa] 48000Hz 2ch floatle (4 bytes per sample)
Video: no video
Position: 100 %
A: 207.3 (03:27.2) of 207.3 (03:27.3)  0.0% 


Playing /home/oleerik/Music/yplayer/Free.mp3 (The Pirate Bay Song).mp3.
libavformat file format detected.
[lavf] stream 0: audio (opus), -aid 0, -alang eng
Clip info:
 encoder: google

==========================================================================
Opening audio decoder: [ffmpeg] FFmpeg/libavcodec audio decoders
AUDIO: 48000 Hz, 2 ch, floatle, 0.0 kbit/0.00% (ratio: 0->384000)
Selected audio codec: [ffopus] afm: ffmpeg (FFmpeg opus)
==========================================================================
AO: [alsa] 48000Hz 2ch floatle (4 bytes per sample)
Video: no video
Starting playback...
A:  52.5 (52.4) of 207.3 (03:27.3)  1.2% 

No idea what to do about that. Not too bad anyways!

@96AA48

This comment has been minimized.

Show comment
Hide comment
@96AA48

96AA48 Nov 16, 2015

Owner

Hey @oleerik , great work. My apologies for my late response. I'll look at it tomorrow, I'm getting tired of programming for today. I'll merge it when I feel it works well enough.

Owner

96AA48 commented Nov 16, 2015

Hey @oleerik , great work. My apologies for my late response. I'll look at it tomorrow, I'm getting tired of programming for today. I'll merge it when I feel it works well enough.

96AA48 added a commit that referenced this pull request Nov 21, 2015

@96AA48 96AA48 merged commit e2030b6 into 96AA48:master Nov 21, 2015

@96AA48

This comment has been minimized.

Show comment
Hide comment
@96AA48

96AA48 Nov 21, 2015

Owner

The changes have been merged and the new version v0.2.4 has been released on npm. Thanks for your contribution!

Owner

96AA48 commented Nov 21, 2015

The changes have been merged and the new version v0.2.4 has been released on npm. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment