hikey960: Fix broken images #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent grand renaming left many of the image links in the hikey960 doc broken. Fix them. Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
|
@daniel-thompson Same issue for Hikey620 also. Do you have any plans to nail it together? Else we will do it |
|
On Fri, Aug 24, 2018 at 02:46:53AM -0700, Manivannan Sadhasivam wrote:
@daniel-thompson Same issue for Hikey620 also. Do you have any plans to nail it together? Else we will do it
No plans on my side. This was spotted by a user so I put in the PR (and
also it was easy to do with sed). To be honest it might be worth trying
to figure out why the link checker isn't checking image links. That way
we could squash the entire bug class!
… --
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#578 (comment)
|
|
@daniel-thompson AFAIK the redirect links are fetched from a JSON file rather than from the individual docs. But @kylekirkby is the person who knows more about this issue! |
ric96
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent grand renaming left many of the image links in the hikey960 doc
broken. Fix them.
Signed-off-by: Daniel Thompson daniel.thompson@linaro.org