Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login flag behavior to match that of identical flags on exec #385

Merged
merged 2 commits into from Jun 23, 2019
Merged

Fix login flag behavior to match that of identical flags on exec #385

merged 2 commits into from Jun 23, 2019

Conversation

rossmckelvie
Copy link
Contributor

  • --assume-role-ttl on exec honored the environment variable AWS_ASSUME_ROLE_TTL. This has been fixed for login command
  • --profile on exec has a hint if not passed in, added this to login command

@mtibben mtibben merged commit 4a34d94 into 99designs:master Jun 23, 2019
@mtibben
Copy link
Member

mtibben commented Jun 23, 2019

Thanks @rossmckelvie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants