From c770b4e75b1206130441c8d2a06e05ea44b4715a Mon Sep 17 00:00:00 2001 From: Evan Shaw Date: Sun, 2 Sep 2018 12:03:25 +1200 Subject: [PATCH] Use built-in less than operator instead of strings.Compare --- codegen/enum_build.go | 2 +- codegen/input_build.go | 3 +-- codegen/interface_build.go | 3 +-- codegen/models_build.go | 3 +-- codegen/object_build.go | 3 +-- 5 files changed, 5 insertions(+), 9 deletions(-) diff --git a/codegen/enum_build.go b/codegen/enum_build.go index 55cb957bdc..457d923f22 100644 --- a/codegen/enum_build.go +++ b/codegen/enum_build.go @@ -32,7 +32,7 @@ func (cfg *Config) buildEnums(types NamedTypes) []Enum { } sort.Slice(enums, func(i, j int) bool { - return strings.Compare(enums[i].GQLType, enums[j].GQLType) == -1 + return enums[i].GQLType < enums[j].GQLType }) return enums diff --git a/codegen/input_build.go b/codegen/input_build.go index 1059601a3c..06ff37a091 100644 --- a/codegen/input_build.go +++ b/codegen/input_build.go @@ -3,7 +3,6 @@ package codegen import ( "go/types" "sort" - "strings" "github.com/pkg/errors" "github.com/vektah/gqlparser/ast" @@ -38,7 +37,7 @@ func (cfg *Config) buildInputs(namedTypes NamedTypes, prog *loader.Program, impo } sort.Slice(inputs, func(i, j int) bool { - return strings.Compare(inputs[i].GQLType, inputs[j].GQLType) == -1 + return inputs[i].GQLType < inputs[j].GQLType }) return inputs, nil diff --git a/codegen/interface_build.go b/codegen/interface_build.go index 5ffcbcedab..9f4a4ff4d5 100644 --- a/codegen/interface_build.go +++ b/codegen/interface_build.go @@ -5,7 +5,6 @@ import ( "go/types" "os" "sort" - "strings" "github.com/vektah/gqlparser/ast" "golang.org/x/tools/go/loader" @@ -20,7 +19,7 @@ func (cfg *Config) buildInterfaces(types NamedTypes, prog *loader.Program) []*In } sort.Slice(interfaces, func(i, j int) bool { - return strings.Compare(interfaces[i].GQLType, interfaces[j].GQLType) == -1 + return interfaces[i].GQLType < interfaces[j].GQLType }) return interfaces diff --git a/codegen/models_build.go b/codegen/models_build.go index b57eafff5c..9f98a07dd5 100644 --- a/codegen/models_build.go +++ b/codegen/models_build.go @@ -2,7 +2,6 @@ package codegen import ( "sort" - "strings" "github.com/vektah/gqlparser/ast" "golang.org/x/tools/go/loader" @@ -47,7 +46,7 @@ func (cfg *Config) buildModels(types NamedTypes, prog *loader.Program, imports * } sort.Slice(models, func(i, j int) bool { - return strings.Compare(models[i].GQLType, models[j].GQLType) == -1 + return models[i].GQLType < models[j].GQLType }) return models, nil diff --git a/codegen/object_build.go b/codegen/object_build.go index 8573ad2402..ee2b2f1c2b 100644 --- a/codegen/object_build.go +++ b/codegen/object_build.go @@ -3,7 +3,6 @@ package codegen import ( "log" "sort" - "strings" "github.com/pkg/errors" "github.com/vektah/gqlparser/ast" @@ -38,7 +37,7 @@ func (cfg *Config) buildObjects(types NamedTypes, prog *loader.Program, imports } sort.Slice(objects, func(i, j int) bool { - return strings.Compare(objects[i].GQLType, objects[j].GQLType) == -1 + return objects[i].GQLType < objects[j].GQLType }) return objects, nil