Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert issue 2470 #2577

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Revert issue 2470 #2577

merged 3 commits into from
Mar 7, 2023

Conversation

atzedus
Copy link
Contributor

@atzedus atzedus commented Mar 6, 2023

PR closes issues #2523 and #2541 by reverting commit from #2470

It was my mistake, i can't reproduce this any way.

I add test case to prevent this from happening in the future.

I have:

  • [ x ] Added tests covering the bug / feature (see testing)

@coveralls
Copy link

coveralls commented Mar 6, 2023 •
edited
Loading

Coverage Status

Coverage: 78.812% (+3.4%) from 75.368% when pulling 5f6b4fd on atzedus:revert-issue-2470 into cac5f0f on 99designs:master.

@StevenACoffman StevenACoffman merged commit dcd7555 into 99designs:master Mar 7, 2023
@atzedus atzedus deleted the revert-issue-2470 branch March 7, 2023 12:17
@StevenACoffman StevenACoffman mentioned this pull request Mar 7, 2023
Closed
@jwatte
Copy link

jwatte commented Sep 8, 2023

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atzedus @coveralls @jwatte @StevenACoffman