Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix go syntax issue when field has 2 directives #829

Merged
merged 1 commit into from Aug 16, 2019
Merged

Conversation

vvakame
Copy link
Collaborator

@vvakame vvakame commented Aug 13, 2019

Describe your PR and link to any relevant issues.

current code template will make invalid go code.

		directive1 := func(ctx context.Context) (interface{}, error) {
			return ec.directives.Directive1(ctx, nil, directive0)
		}directive2 := func(ctx context.Context) (interface{}, error) {
			return ec.directives.Directive2(ctx, nil, directive1)
		}

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@davidp94
Copy link

@vvakame Thank you I wanted to do the same PR :)

@vvakame vvakame requested a review from vektah August 14, 2019 02:17
@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.817% when pulling cc9fe14 on fix-2directives into 6b70be0 on master.

@vvakame
Copy link
Collaborator Author

vvakame commented Aug 15, 2019

fixes #785

@vektah vektah merged commit fc02cfe into master Aug 16, 2019
@vektah vektah deleted the fix-2directives branch August 16, 2019 05:30
@vektah vektah added the v0.9.3 label Aug 16, 2019
cgxxv pushed a commit to cgxxv/gqlgen that referenced this pull request Mar 25, 2022
fix go syntax issue when field has 2 directives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants