Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

9pfuse: Disable glibc workaround for O_LARGEFILE on ARM #4

Closed
wants to merge 1 commit into from

2 participants

Merlijn Wajer Russ Cox
Merlijn Wajer

9pfuse fails on ARM when O_LARGEFILE is supported. glibc does define O_LARGEFILE properly on ARM, and the value is different than what that this workaround suggests, causing it to wrongly detect bad flags.

Merlijn Wajer MerlijnWajer 9pfuse: Disable glibc workaround for O_LARGEFILE on ARM
9pfuse fails on ARM when O_LARGEFILE is supported. glibc does define O_LARGEFILE properly on ARM, and the value is different than what that this workaround suggests, causing it to wrongly detect bad flags.
29c51b6
Merlijn Wajer

To be clear: the fixes an error message that wrongly detects bad flags in the open function: _fuseopen With this fix applied, the code should at least allow you to perform read and stat actions.

Russ Cox
Owner
rsc commented

Thank you. I merged this via Gerrit https://plan9port-review.googlesource.com/1094.

Please see the new CONTRIBUTING.md for future changes. Pull requests are not the best medium.

Russ Cox rsc closed this
Merlijn Wajer

Alright; thanks. I will do that in the future.

Merlijn Wajer MerlijnWajer deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 18, 2014
  1. Merlijn Wajer

    9pfuse: Disable glibc workaround for O_LARGEFILE on ARM

    MerlijnWajer authored
    9pfuse fails on ARM when O_LARGEFILE is supported. glibc does define O_LARGEFILE properly on ARM, and the value is different than what that this workaround suggests, causing it to wrongly detect bad flags.
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 1 deletion.
  1. +4 −1 src/cmd/9pfuse/main.c
5 src/cmd/9pfuse/main.c
View
@@ -34,8 +34,11 @@
* 0100000 in the kernel) at each file open. FUSE is all too
* happy to pass the flag onto us, where we'd have no idea what
* to do with it if we trusted glibc.
+ *
+ * On ARM however, the O_LARGEFILE is set correctly.
*/
-#if defined(__linux__)
+
+#if defined(__linux__) && !defined(__arm__)
# undef O_LARGEFILE
# define O_LARGEFILE 0100000
#endif
Something went wrong with that request. Please try again.