Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing compiler warnings with collections and inheritance #22

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@evilglee
Copy link

evilglee commented Apr 11, 2014

When one immutable type descends from another immutable type that contains a collection, the generated code produces compiler warnings because of methods with the same name.

@AArnott

This comment has been minimized.

Copy link
Owner

AArnott commented Apr 19, 2014

Thanks.

@ProductiveRage

This comment has been minimized.

Copy link

ProductiveRage commented Sep 29, 2014

Do you mind if I ask why this wasn't merged in? It appears trouble-free from what I understand and those warnings were nagging me when I was building the solution! :)

@IanYates

This comment has been minimized.

Copy link

IanYates commented Sep 30, 2014

Hi @ProductiveRage (glad to see you here after putting the link in your blog comments). This PR hasn't caused me any grief in my use of the code.

@ProductiveRage

This comment has been minimized.

Copy link

ProductiveRage commented Sep 30, 2014

Hi! Yes :) I've tried out the code here a little bit - and it's exercised by the XmlNode.tt template in the ImmutableObjectGraph.Tests project and it seems to correctly use "public" on the XmlElementWithContent "content" update method and "public new" for the update methods of fields in the XmlElement type that it inherits from. Which is all good!

@AArnott

This comment has been minimized.

Copy link
Owner

AArnott commented Nov 5, 2014

I'm sorry I haven't gotten to this yet. And I do appreciate your pull
request. I have been actively working on this project in an internal form,
and working with my manager to be able to publicly release that as well.

On Tue, Sep 30, 2014, 3:26 AM ProductiveRage notifications@github.com
wrote:

Hi! Yes :) I've tried out the code here a little bit - and it's exercised
by the XmlNode.tt template in the ImmutableObjectGraph.Tests project and it
seems to correctly use "public" on the XmlElementWithContent "content"
update method and "public new" for the update methods of fields in the
XmlElement type that it inherits from. Which is all good!


Reply to this email directly or view it on GitHub
#22 (comment)
.

@IanYates

This comment has been minimized.

Copy link

IanYates commented Nov 5, 2014

@AArnott - Looking forward to whatever magic is coming our way :) After that I'd like to try my first pull request ever and submit my changes to the library, although they're probably not to everyone's taste (the ability to define "keys" on entities and some equality overrides, etc). Maybe it's better off in a public fork. Anyway, I'll hold off until other things come along.

@AArnott

This comment has been minimized.

Copy link
Owner

AArnott commented Nov 20, 2014

I've just pushed the last year or so's worth of commits to be public (a7680c3..c70b6ef yay!). But I'm afraid it introduced merge conflicts in your pull request. Please consider merging master into your branch, resolving conflicts, and updating this.

Please re-open or re-submit pull request after the update if you make one. Thanks again.

@AArnott AArnott closed this Nov 20, 2014

@AArnott

This comment has been minimized.

Copy link
Owner

AArnott commented Nov 23, 2014

The new Roslyn-based code generation includes a test verification to ensure that the generated code has no warnings in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.