New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change password hashing #33

Merged
merged 5 commits into from Jun 13, 2017

Conversation

Projects
None yet
3 participants
@Repflez
Contributor

Repflez commented Apr 12, 2015

Since people are starting to make pull requests for anything, I should join the fun.

This pull changes how passwords are hashed on the board, making use of the password hashing API that appeared in PHP 5.5 with a compatibility library for past versions of PHP.

This also has the side effect of bumping the minimal version to 5.3.7 or greater and the installer has been edited to reflect this.

This change converts all ABXD passwords when the user logs in again so users should log out and log in to have their password changed to the new hashing.

Note: It also blanks pss on every user when converting the password but I don't know what it could affect on the board.

Repflez added some commits Apr 12, 2015

Make use of PHP 5.5 password hashing API on the board.
The current implementation also converts all legacy passwords to the current one.
If PHP 5.5 is not installed on the server, a compatibility library is used.
Require PHP 5.3.7 or greater on install.
This is required by the password compatibility library.
@Repflez

This comment has been minimized.

Contributor

Repflez commented Apr 12, 2015

Fixed an obvious issue and restored pss. I'm not going to risk it so I'm leaving it alone.

Restore pss on editprofile.php
Forgot about that one.
@ghost

This comment has been minimized.

ghost commented Jun 19, 2016

You broke the installer by the way because I tried to install your ABXD version here and it says 'You need php 5.3.7 or greater and you are running 5.3.27' which is an obvious bug...

@Nadia-h Nadia-h merged commit 26abaa8 into ABXD:master Jun 13, 2017

@phase

This comment has been minimized.

phase commented Jun 13, 2017

It lives!

@Repflez

This comment has been minimized.

Contributor

Repflez commented Jun 16, 2017

Oh wow, what. Oh well.

RE: Installer breakage: oops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment