Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SendToRoute with routing hints #1325

Merged
merged 2 commits into from Feb 18, 2020
Merged

SendToRoute with routing hints #1325

merged 2 commits into from Feb 18, 2020

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Feb 17, 2020

SendToRoute previously didn't accept invoice routing hints.
This was a limitation when paying a wallet invoice.
Invoice hints are now correctly taken into account.

SendToRoute previously didn't accept invoice routing hints.
This was a limitation when paying a wallet invoice.
Invoice hints are now correctly taken into account.
@t-bast t-bast requested a review from araspitzu Feb 17, 2020
@codecov-io
Copy link

codecov-io commented Feb 17, 2020

Codecov Report

Merging #1325 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
+ Coverage   77.52%   77.59%   +0.07%     
==========================================
  Files         144      144              
  Lines       10134    10137       +3     
  Branches      412      411       -1     
==========================================
+ Hits         7856     7866      +10     
+ Misses       2278     2271       -7
Impacted Files Coverage Δ
...r/acinq/eclair/payment/send/PaymentLifecycle.scala 92.8% <100%> (ø) ⬆️
...src/main/scala/fr/acinq/eclair/router/Router.scala 93.27% <100%> (+0.7%) ⬆️
...r/acinq/eclair/payment/send/PaymentInitiator.scala 95.89% <100%> (ø) ⬆️
...-core/src/main/scala/fr/acinq/eclair/io/Peer.scala 76.85% <0%> (+0.28%) ⬆️
...q/eclair/blockchain/electrum/ElectrumWatcher.scala 55.2% <0%> (+1.6%) ⬆️

araspitzu
araspitzu previously approved these changes Feb 18, 2020
Copy link
Contributor

@araspitzu araspitzu left a comment

Looks good to me!

@t-bast t-bast merged commit 4579462 into master Feb 18, 2020
4 checks passed
@t-bast t-bast deleted the send-to-route-invoice-hints branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants