Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kamon #1411

Merged
merged 3 commits into from May 6, 2020
Merged

Update kamon #1411

merged 3 commits into from May 6, 2020

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented May 6, 2020

Update Kamon libraries.
Remove log spam in PostRestartHtlcCleaner.

Fixes #1410

@t-bast t-bast requested a review from pm47 May 6, 2020 07:22
@pm47
Copy link
Member

pm47 commented May 6, 2020

How come we didn't stumble into this ourselves?

We probably can get rid of kamon.version since each sub module has its own independent version.

@sstone
Copy link
Member

sstone commented May 6, 2020

Latest version for kamon (kamon-akka, kamon-apm-reporter, kamon-jdbc, kamon-system-metrics) is 2.1.0. Here we use 3 different, similar versions (2.0.2, 2.0.3, 2.0.5) which is a bit confusing. Unless there's a good reason for using different versions for the kamon modules, have a proper definition for kamon.version is cleaner.

@t-bast
Copy link
Member Author

t-bast commented May 6, 2020

Agreed @sstone, I used the versions we are currently using on our nodes because we know they work. PM is currently testing version 2.1.0, if that works I'll update the PR with that!

@pm47
Copy link
Member

pm47 commented May 6, 2020

Unless there's a good reason for using different versions for the kamon modules

They have the habit of starting from a base version for all modules, then independently update each module. That's why it's a bit difficult to factor.

t-bast added 2 commits May 6, 2020 15:25
Otherwise this generated messages to deadletters for new channels.
This is just to reduce spam in logs.
@t-bast t-bast merged commit 3f127fb into master May 6, 2020
@t-bast t-bast deleted the update-kamon branch May 6, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.4 upgrade to Akka 2.6 which I think broke Kamon monitoring
3 participants