Conversation
It's handy to update relay fees for multiple channels at once. Closing and force-closing channels may also make sense to do in batch. Closes #1432
araspitzu
reviewed
May 28, 2020
Contributor
araspitzu
left a comment
araspitzu
left a comment
There was a problem hiding this comment.
Left some minor nits but changes ACK 👍
eclair-node/src/main/scala/fr/acinq/eclair/api/ExtraDirectives.scala
Outdated
Show resolved
Hide resolved
araspitzu
previously approved these changes
May 28, 2020
Member
Author
|
Actually I didn't test the failing cases thoroughly enough, in case of failures we don't return a map that allows tracking which channel command succeeded and which failed, we only return the failure. I should handle that more cleanly. |
We map all failures to a successful future that contains a Left(throwable). It ensures that we see a response for each requested channels, allowing the application to deal with failures individually.
araspitzu
approved these changes
Jun 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's handy to update relay fees for multiple channels at once.
Closing and force-closing channels may also make sense to do in batch.
I've made a note to update the API documentation when we release these changes.
Closes #1432