Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate onion messages #2133

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Activate onion messages #2133

merged 2 commits into from
Jan 17, 2022

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Jan 17, 2022

I believe we can safely activate onion messages by default in our next release.
It will be interesting to see how people use it and what feature requests emerge.
We already have some rate-limiting with safe defaults in place, so I don't think this creates any risk for node operators.
On top of that, it can be very easily disabled (as explained in the release notes).

I also took this opportunity to fix an issue with the supervisor for MessageRelay actors, which incorrectly inherited the resume strategy (which makes sense for Peer actors).
Running the integration tests with logs activated showed many errors and warnings about this, we should have caught it earlier.
I don't know if it is related to the transient test failure we've seen.

* Fix supervisor for MessageRelay actors
* Use optional replyTo instead of replyTo.NoSender
And improve release notes.
@t-bast t-bast merged commit 546ca23 into master Jan 17, 2022
@t-bast t-bast deleted the activate-onion-messages branch January 17, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants