New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto probing of local channels #762

Merged
merged 10 commits into from Jan 18, 2019

Conversation

Projects
None yet
3 participants
@pm47
Copy link
Member

pm47 commented Nov 19, 2018

This is a simple mechanism to test our direct peers by sending fake
small payments to them. A probe is considered successful if the peer
replies with an UnknownPaymentHash error.

pm47 added some commits Nov 19, 2018

added auto probing of local channels
This is a simple mechanism to test our direct peers by sending fake
small payments to them. A probe is considered successful if the peer
replies with an `UnknownPaymentHash` error.
@btcontract

This comment has been minimized.

Copy link
Contributor

btcontract commented Nov 21, 2018

While at it, what do you think about ACINQ/eclair-mobile#94?
This behavior may be specified in config, it has proven to be a good bug hunting tool in my case.

@pm47

This comment has been minimized.

Copy link
Member Author

pm47 commented Nov 22, 2018

But the point here is to close zombie channels right?

@btcontract

This comment has been minimized.

Copy link
Contributor

btcontract commented Nov 22, 2018

To spot them, yes. What happens next may differ depending on whether this happens on server side or mobile app. In a letter case user may be interested to keep the channel open and let peer fix the bug.

@pm47

This comment has been minimized.

Copy link
Member Author

pm47 commented Nov 23, 2018

I'm not sure this probing should be enabled on eclair-wallet, it makes more sense for always-on nodes

pm47 added some commits Dec 13, 2018

@pm47 pm47 changed the title [WIP] Auto probing of local channels Auto probing of local channels Jan 10, 2019

@pm47 pm47 requested a review from sstone Jan 10, 2019

@pm47

This comment has been minimized.

Copy link
Member Author

pm47 commented Jan 10, 2019

I think this feature could be merged, but disabled by default because:

  • nodes aren't very reliable on current mainnet and this would probably cause too many channels to get closed for our users
  • there is currently no way to tell destination node it is being probed, so that could cause unnecessary support work
@sstone

sstone approved these changes Jan 18, 2019

@pm47 pm47 merged commit a52acdc into master Jan 18, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@pm47 pm47 deleted the auto-probe-htlc branch Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment