Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: replace JSON-RPC by named parameters #894

merged 90 commits into from Mar 26, 2019


None yet
5 participants
Copy link

araspitzu commented Mar 13, 2019

Port the existing API functionalities over a new structure of HTTP endpoints, with the biggest difference being the usage of named parameters for the requests (responses are unchanged). RPC methods have become endpoints and the parameters for each are now passed via form-params (clients must use the header "Content-Type" : "multipart/form-data"), this allows for a clearer interpretation of the parameters and results in more elegant parsing code on the server side. It is possible to still use the old API version via a configuration key.

sstone and others added some commits Dec 14, 2018

Bitcoin RPC: use `signrawtransactionwithwallet`
We don't use `signrawtransaction` anymore, which was deprecated in Bitcoin Core 0.17
and will be removed in 0.18.

This means that we don't support 0.16.3 and older.
Remove unused travis files
We download bitcoin core and check with maven now.
Check that bitcoind version is 0.17.0 or higher
Plus minor code reformatting for some tests.
BitcoinCoreWallet: add signing tests with multiple bad inputs
Check that we handle errors properly when signrawtransactionwithwallet returns multiple errors.

araspitzu added some commits Mar 25, 2019

dpad85 and others added some commits Mar 25, 2019

Added short options to eclair-cli, and removed color option
Short options adds a jq filter for some methods such as channels or
channel in order to ouput a smaller and more readable json.

Color option has been removed because it adds ansi special characters
which breaks jq piping on some systems.

araspitzu added some commits Mar 26, 2019

araspitzu added some commits Mar 26, 2019

Merge branch 'master' into api_revamp
# Conflicts:
#	eclair-core/src/main/scala/fr/acinq/eclair/api/Service.scala

@araspitzu araspitzu requested review from sstone, pm47 and dpad85 Mar 26, 2019

pm47 and others added some commits Mar 26, 2019

Changed addressed and reviewed


pm47 approved these changes Mar 26, 2019

@dpad85 dpad85 dismissed their stale review Mar 26, 2019



sstone approved these changes Mar 26, 2019


dpad85 approved these changes Mar 26, 2019

@pm47 pm47 merged commit a4b9400 into master Mar 26, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@pm47 pm47 deleted the api_revamp branch Mar 26, 2019

@pm47 pm47 referenced this pull request Mar 27, 2019


Cleanup internal Eclair API #653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.