Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Live channel database backup #951
Backups are handled by a custom actor that listens to persistence events sent by channels. They are done in 2 steps:
Users would typically rename/move the backup file then make a safe copy of it.
Backups are sequential. If backup requests pile up while a backup is still in progress, only the last one will be kept.
A few bikeshed comments, overall looks good to me. The PR is missing assumptions that we are making on the number of channels.
Also this should include an update to the documentation.