New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports are sent via the SenderService in a separate process. #344

Merged
merged 3 commits into from Jan 4, 2016

Conversation

Projects
None yet
1 participant
@william-ferguson-au
Member

william-ferguson-au commented Jan 4, 2016

This is an enhanced version of #329
And fixes the issue in #327

It introduces SenderService that performs all report sending and by default performs it in another process (which avoids the problems with OKHttp trying to start a Thread while the VM is shutting down).

It doesn't enable the UncaughtExceptionHandler for ACRA if the current process is the SenderService. This avoids infinite loop crashes on start.

It allows declarative or programmatic config of ReportSenderFactories.

NOTE: It has a BREAKING API change in ErrorReport for config of ReportSenders, because you need to provide a ReportSenderFactory CLASS rather than a ReportSender instance so that we can correctly configure the SenderService.

william-ferguson-au added some commits Jan 4, 2016

Reports are now sent from the SenderService which should be (and is b…
…y default) started in another process.

ReportSenders are now configured via configuring ReportSenderFactory classes in ErrorReporter (NB this is a BREAKING API change).
Moving SenderService and SenderWorker to org.acra.sender package.
Moving CrashReport* classes to org.acra.common package.

william-ferguson-au added a commit that referenced this pull request Jan 4, 2016

Merge pull request #344 from ACRA/romansl-master
SendWorker now works in the separate process service.

@william-ferguson-au william-ferguson-au merged commit cf3cf27 into master Jan 4, 2016

@william-ferguson-au william-ferguson-au deleted the romansl-master branch Jan 4, 2016

@william-ferguson-au william-ferguson-au changed the title from SendWorker now works in the separate process service. to Reports are sent via the SenderService in a separate process. Jan 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment