Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2016-4855: XSS vulnerability in old test script #274

Closed
dregad opened this issue Aug 28, 2016 · 1 comment
Closed

CVE-2016-4855: XSS vulnerability in old test script #274

dregad opened this issue Aug 28, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@dregad
Copy link
Member

dregad commented Aug 28, 2016

JPCERT Coordination Center (JPCERT/CC) reported the following vulnerability in ADOdb.

As a workaround until hotfix is released, we recommend all users to remove the whole ./tests directory; it is only used for development purposes and is not necessary for normal ADOdb operations.


Report description

[Reference Number]
JVN#48237713

[Title]

  • ADOdb vulnerable to cross-site scripting

[Reporter Related Information]

  • Anonymous (reporter information was not provided)

[Vulnerability Information]

  • This vulnerability was found by the reporter
  • Product Name: ADOdb
    Version: 5.20.4
    Language: PHP
  • Description:
    Cross-site scripting
  • Reproduction Procedure:
    • Environment used:
      OS: Windows 7
      Middleware: Most recent version of xampp

      Place the most recent version of xampp at c:\xampp

      Place ADOdb at C:\xampp\htdocs\AUDIT\adodb5

      Using Chrome with the XSS filter turned off, access

      http://localhost/AUDIT/adodb5/tests/test.php?testproxy=1&ADODB_vers=V123%3Cscript%3Ealert(1)%3C/script%3E
      

      to reproduce the vulnerability. Here an alert dialog will appear.

[Possible Impacts]

  • Cookies may be stolen
  • Pages may be defaced
  • Other affects of XSS

[Possible Workarounds]

  • None

[Proof-of-Concept Code]

  • None

[Other Information]

  • None

[Report Validation and Comments from IPA]

  • None

[Comments from JPCERT/CC]

  • None
@dregad dregad added this to the v5.20.6 milestone Aug 28, 2016
@dregad dregad self-assigned this Aug 28, 2016
dregad added a commit that referenced this issue Aug 28, 2016
This issue was reported by JPCERT Coordination Center (JPCERT/CC) with
reference JVN#48237713.

The root cause is a foreach loop processing all GET parameters and
blindly assigning them to variables, allowing an attacker to
replace contents of global variables.

This limits variable processing using a regex matching those used in
testdatabases.inc.php (i.e. beginning with 'test' or 'no').

Fixes #274
dregad added a commit that referenced this issue Aug 28, 2016
It is only used for development purposes and is not necessary for normal
ADOdb operations.

Issue #274
@dregad dregad closed this as completed Aug 28, 2016
@dregad dregad changed the title XSS vulnerability in old test script CVE-2016-4855: XSS vulnerability in old test script Aug 31, 2016
@dregad
Copy link
Member Author

dregad commented Sep 6, 2016

JPCERT/CC advisory JVN#48237713 was published today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant