New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem transfering files with brackets in filename #53

Closed
Mark-Five opened this Issue Oct 10, 2018 · 8 comments

Comments

Projects
None yet
2 participants
@Mark-Five
Copy link

Mark-Five commented Oct 10, 2018

Platform : Win10 x64
Java : 8/181 x64 (latest)
Using ADTPro release 2.0.3 on apple //e with SSC
Filename : SHERWOOD FOREST (1982)(PHOENIX SOFTWARE).dsk

Content of trace window :
Exception in thread "Thread-2" java.util.regex.PatternSyntaxException: Unclosed group near index 40
SHERWOOD FOREST (1982)(PHOENIX SOFTWAR..
at java.util.regex.Pattern.error(Unknown Source)
at java.util.regex.Pattern.accept(Unknown Source)
at java.util.regex.Pattern.group0(Unknown Source)
at java.util.regex.Pattern.sequence(Unknown Source)
at java.util.regex.Pattern.expr(Unknown Source)
at java.util.regex.Pattern.compile(Unknown Source)
at java.util.regex.Pattern.(Unknown Source)
at java.util.regex.Pattern.compile(Unknown Source)
at java.util.regex.Pattern.matches(Unknown Source)
at java.lang.String.matches(Unknown Source)
at org.adtpro.gui.Gui$1.accept(Unknown Source)
at java.io.File.list(Unknown Source)
at org.adtpro.gui.Gui.getFiles(Unknown Source)
at org.adtpro.CommsThread.sendDirectoryWide(Unknown Source)
at org.adtpro.CommsThread.dispatchCommand(Unknown Source)
at org.adtpro.CommsThread.commandLoop(Unknown Source)
at org.adtpro.CommsThread.run(Unknown Source)

Renaming the file (removal of brackets) solves the problem.

@Mark-Five Mark-Five changed the title Problem transfering files with parenthesis in filename Problem transfering files with brackets in filename Oct 10, 2018

@david-schmidt

This comment has been minimized.

Copy link
Contributor

david-schmidt commented Oct 10, 2018

Good catch. Is this because you had selected the file via wildcard on the client end, or did you type it all out?

@Mark-Five

This comment has been minimized.

Copy link

Mark-Five commented Oct 10, 2018

Pressed R for receive, then RETURN.
Then selected the file using arrow keys and RETURN again.
Funny thing is that it's starting something on the serial port.
After that, I have to disconnect/reconnect (on the PC software) to regain access to ADTPro.

@david-schmidt

This comment has been minimized.

Copy link
Contributor

david-schmidt commented Oct 10, 2018

Got it, this is via the arrow/return interface. Another thing is also true - if the file (name) is actually longer than the screen, it will simply fail to find the file (since the file name is passed as-is-viewed to the server).

@Mark-Five

This comment has been minimized.

Copy link

Mark-Five commented Oct 10, 2018

Yep. Also noticed this one but thought the filename was just too long.
I can help on the 6502 part but I suck at java.

@david-schmidt

This comment has been minimized.

Copy link
Contributor

david-schmidt commented Oct 10, 2018

@Mark-Five

This comment has been minimized.

Copy link

Mark-Five commented Oct 10, 2018

That would sure be a great enhancement.
At least for me since I'm far too lazy to type a filename :-)

@david-schmidt

This comment has been minimized.

Copy link
Contributor

david-schmidt commented Oct 10, 2018

Notes:
In hostfns.asm: NIBPCNT holds the current page number, NDULASTROW is current vertical position on screen; it will be 3-indexed (first row is actually 4th on screen due to header).

In conio.asm: SCRAPE: can be retrained to encode the page and row; a payload like 0x01<page_byte><vertical_byte>0x00 or something like that.

Protocol extension to Query File Size and Image Get will understand the leading 0x01 in the payload to mean this coordinate system rather than a text name. Reply from the host can remain unchanged.

@david-schmidt

This comment has been minimized.

Copy link
Contributor

david-schmidt commented Oct 11, 2018

Merged - will be part of next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment