Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow swiping through cards in Deck builder #231

Open
deepbrook opened this issue Jul 31, 2017 · 3 comments
Open

Allow swiping through cards in Deck builder #231

deepbrook opened this issue Jul 31, 2017 · 3 comments

Comments

@deepbrook
Copy link

It's currently not possible to view a card and swipe left / right to look at the next card. I would expect it to behave like the card search in this case.

As of now, you appear to have to switch back to the overview, select the next card, always go through the counter pop-up, before finally being able to see the next card text.

@XVicarious
Copy link
Contributor

I'm not entirely sure what you mean by this. Could you elaborate? Or maybe draw something up to help me visualize it?

@AEFeinstein
Copy link
Owner

Here's my interpretation. From the main search, if you search for elves, you see a list of elves (ResultListFragment). Then when you tap an elf you see the CardViewFragment and can swipe left and right to see the other elves in the ResultListFragment, because the CardViewFragment is embedded in a CardViewPagerFragment. I think the goal here is to have the deck work the same way so when you view a card directly from the deck builder instead of displaying only the CardViewFragment, it would use a CardViewPagerFragment and have the whole deck contents, swipable.

This wouldn't be too hard. Search for CARD_ID_ARRAY and STARTING_CARD_POSITION and see how lists of cards are passed into the CardViewPagerFragment.

@XVicarious
Copy link
Contributor

Ohhhh, okay. I get it now. I just did have an idea for a grid-based deck view that I'm working on right now that could make that moot. Although it might still be something to look into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants