Skip to content

Feature/hello world#1

Open
TheDarkKnightAelf wants to merge 8 commits into
masterfrom
feature/hello-world
Open

Feature/hello world#1
TheDarkKnightAelf wants to merge 8 commits into
masterfrom
feature/hello-world

Conversation

@TheDarkKnightAelf

Copy link
Copy Markdown

HelloWorld Contract with Update and Read methods.

@vizipi

vizipi Bot commented Jun 8, 2023

Copy link
Copy Markdown

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
77.50 % gldeng 1 62
15.00 % yimeng.lu 1 12

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
src/ContractsReferences.cs50.00 %1 out of 2 times
src/HellowWorldConstants.cs50.00 %1 out of 2 times
src/HellowWorldHelpers.cs50.00 %1 out of 2 times

Committed file ranks

(click to expand)
  • 30.39%[basics/hello-world/test/HellowWorldTestsInitialization.cs]
  • 30.39%[...basics/hello-world/src/Protobuf/contract/hello_world_cont]
  • 0.00%[basics/hello-world/src/AElf.Contracts.HelloWorld.csproj]
  • 0.00%[basics/hello-world/src/HelloWorldState.cs]
  • 0.00%[basics/hello-world/src/HelloWorld.cs]
  • 0.00%[...basics/hello-world/test/AElf.Contracts.HelloWorld.Tests.c]
  • 30.39%[...basics/hello-world/test/Protobuf/stub/hello_world_contrac]
  • 30.39%[basics/hello-world/test/_Setup.cs]
  • 0.00%[basics/hello-world/test/HelloWorldTests.cs]
  • 30.39%[...basics/hello-world/test/Protobuf/message/authority_info.p]
  • @vizipi vizipi Bot requested a review from gldeng June 12, 2023 05:49
    @vizipi vizipi Bot requested a review from ymlalf June 14, 2023 18:29

    Copy link
    Copy Markdown
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Need to fix class name.
    Fixed in the next commit.

    Copy link
    Copy Markdown
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Need to remove useless ItemGroup tags, update dependencies.
    Fixed in the next commit.

    Copy link
    Copy Markdown
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Need to fix class name.
    Fixed in the next commit.

    Copy link
    Copy Markdown
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Need to fix class name.
    Fixed in the next commit.

    Copy link
    Copy Markdown
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Need to remove useless ItemGroup tags, update dependencies, modify namespace.
    Fixed in the next commit.

    Copy link
    Copy Markdown
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Need to fix class name.
    Fixed in the next commit.

    Copy link
    Copy Markdown
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Need to update namespace.
    Fixed in the next commit.

    Copy link
    Copy Markdown
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Need to update namespace.
    Fixed in the next commit.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants