Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new mode to AFLplusplus #1374

Merged
merged 3 commits into from Apr 3, 2022
Merged

Conversation

CarloMara
Copy link

@CarloMara CarloMara commented Apr 1, 2022

Hello everybody,

after long discussion with @domenukk, I have completed the first patch to enable the new mode. See screenshot attached for the first general overview.

Following @domenukk advice, I've added a new flag to make this opt in, at least while it's still under test.

Cheers all,
Carlo
image

@domenukk
Copy link
Member

domenukk commented Apr 1, 2022

Thank you for your contribution! The initial implementation already looks very good!
Please direct PRs towards the dev branch 🤌.

src/afl-fuzz-state.c Outdated Show resolved Hide resolved
void show_stats(afl_state_t *afl) {
if(afl->afl_env.afl_pizza_mode){
Copy link
Member

@domenukk domenukk Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be likely()

@nezza
Copy link

nezza commented Apr 1, 2022

I can confirm that this patch works on my system as designed. Only comment would be to add TikTok support, I saw that a lot of new pizza types appear there first. How complex would that change be? And can this be extended to support pasta dishes?

@fabianfreyer
Copy link

fabianfreyer commented Apr 1, 2022

It's lacking stats on number of cans of pineapple used, average number of pineapple pizza pieces per pizza, etc...

@andreafioraldi
Copy link
Member

andreafioraldi commented Apr 1, 2022

at least still 0 pineapple pizzas cooked

@andreafioraldi
Copy link
Member

andreafioraldi commented Apr 1, 2022

Testing abourted by the user -> Baking aborted by the chef
second at table -> # ordered peroni

time_tmp, tmp);

SAYF(bVR bH bSTOP cCYA
" Backing progress " bSTG bH30 bH20 bH5 bX bH bSTOP cCYA
Copy link

@carpikes carpikes Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
" Backing progress " bSTG bH30 bH20 bH5 bX bH bSTOP cCYA
" Baking progress " bSTG bH30 bH20 bH5 bX bH bSTOP cCYA

Copy link
Member

@andreafioraldi andreafioraldi Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so italian @CarloMara

src/afl-fuzz-stats.c Outdated Show resolved Hide resolved
src/afl-fuzz-stats.c Outdated Show resolved Hide resolved
src/afl-fuzz-stats.c Outdated Show resolved Hide resolved

/* Aaaalmost there... hold on! */

SAYF(bVR bH cCYA bSTOP " Promotional campaign on Facebook yields " bSTG bH30 bH2
Copy link

@carpikes carpikes Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't be a boomer.
s/Facebook/TikTok/

@fabianfreyer
Copy link

fabianfreyer commented Apr 1, 2022

@andreafioraldi

Testing abourted by the user -> Baking aborted by the chef second at table -> # ordered peroni

s/chef/pizzayolo/ ?

src/afl-fuzz-stats.c Outdated Show resolved Hide resolved
@andreafioraldi
Copy link
Member

andreafioraldi commented Apr 1, 2022

s/chef/pizzayolo/ ?

A YOLO pizzaiolo?

@vanhauser-thc vanhauser-thc changed the base branch from stable to dev Apr 1, 2022
@bitwave
Copy link

bitwave commented Apr 1, 2022

Does it support this?
grafik
If so, then please with extra banana, pineapple and kiwi.

@CarloMara
Copy link
Author

CarloMara commented Apr 2, 2022

Hello @domenukk @andreafioraldi,

I've fixed everything as suggested. IMHO it can be merged.

Cheers,
Carlo

@vanhauser-thc vanhauser-thc merged commit ef55436 into AFLplusplus:dev Apr 3, 2022
6 checks passed
abertschi pushed a commit to mattweingarten/AFLplusplus that referenced this issue Apr 21, 2022
* new afl++ experiment

* add variant to fuzzers.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants