Requestfix #2

Merged
merged 2 commits into from May 13, 2012

Projects

None yet

2 participants

Contributor

This Pull Request fixes two issues.

  1. The -(NSURL)baseURL method can return a NSString object instead of a NSURL object.
    I've also changed the logic to always use the bucket name when both it and the baseURL are available.
  2. The setObjectWithMethod:... method was passing the incorrect parameters to the multipartFormRequestWithMethod: which was causing 405's from S3, and failed uploads.
veritech added some commits May 11, 2012
@veritech veritech Stopped the baseURL from being returned as a NSString instead of a NS…
…URL when a using a bucket and base URL
e406b67
@veritech veritech Stopped passing the method and @"/" parameters to the multipart form …
…request factory method instead of the method and path parameters as expected
43b72eb
@mattt mattt merged commit 2f96fff into AFNetworking:master May 13, 2012
Contributor
mattt commented May 13, 2012

Thanks for the fixes, @veritech! I guess I still had a bit more cleanup to do after extracting this from its original project's context. Cheers!

Contributor

No problem, glad to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment