Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed: Use the wrong objectID in new values for Relationship #100

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

pitiphong-p commented Nov 3, 2012

In the

- (id)newValueForRelationship:(NSRelationshipDescription *)relationship
              forObjectWithID:(NSManagedObjectID *)objectID
                  withContext:(NSManagedObjectContext *)context
                        error:(NSError *__autoreleasing *)error

when update the backing objects we use the objectID which is object for the main context. This request is fixed this issue.

Contributor

aprato commented Dec 12, 2012

Unfortunately I didn't see this before fixing the same bug. As mentioned in #117 the same problem may exist around line 442 in the requestForInsertedObject branch of executeSaveChangesRequest:withContext:error: but I don't have a way to test so I'm not touching it at present.

Contributor

mattt commented Jun 19, 2013

Thanks for the patch, @pitiphong-p. Unfortunately, since I took so long to get around to this one, this can't be merged cleanly. On the plus side, I think everything in here was added in some place or another. The latest version of AFIncrementalStore is significantly more stable that it was before. I'm excited to push out a new release soon.

@mattt mattt closed this Jun 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment