Skip to content

typo in attributesForRepresentation #135

Merged
merged 1 commit into from Jan 25, 2013

3 participants

@alvinhu
alvinhu commented Dec 28, 2012

The purpose of attributesForRepresentation is to delete keys and values of representation except attributes of entity. So the mutableKeys should minusSet [entity attributesByName] instead of [entity propertiesByName]. The propertiesByName includes relationship of entity.

@ksm
ksm commented Dec 29, 2012

The code right after (between lines 214 and 217) already removes all representation relationships, except for [NSNull null] relationships (correct my thinking, if I'm wrong here, please!). Your change would strengthen this method by making sure no pesky NSNull relation gets returned in the resulting dictionary. Thumbs up from me for this commit 👍

@mattt mattt merged commit 06f116b into AFNetworking:master Jan 25, 2013
@mattt
mattt commented Jan 25, 2013

Dang, that typo again? I swear, I've probably gotten that wrong more than I got it right. Thanks for the pull request.

@alvinhu alvinhu deleted the alvinhu:typo-in-attributesForRepresentation branch Jan 25, 2013
@alvinhu alvinhu restored the alvinhu:typo-in-attributesForRepresentation branch Jan 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.