New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates AFNetworking dependency to 3.0 #38

Merged
merged 24 commits into from Mar 23, 2018

Conversation

Projects
None yet
8 participants
@dzenbot
Contributor

dzenbot commented Feb 15, 2016

No description provided.

@cameronehrlich

This comment has been minimized.

Show comment
Hide comment
@cameronehrlich

cameronehrlich May 2, 2016

Why is this not getting merged?

cameronehrlich commented May 2, 2016

Why is this not getting merged?

@dzenbot

This comment has been minimized.

Show comment
Hide comment
@dzenbot

dzenbot May 2, 2016

Contributor

Tests failing? Unmaintained project?

Contributor

dzenbot commented May 2, 2016

Tests failing? Unmaintained project?

@cameronehrlich

This comment has been minimized.

Show comment
Hide comment
@cameronehrlich

cameronehrlich May 3, 2016

I realized that was a stupid comment about three seconds after I left the page... haha my bad.

cameronehrlich commented May 3, 2016

I realized that was a stupid comment about three seconds after I left the page... haha my bad.

@aaronschachter aaronschachter referenced this pull request May 27, 2016

Closed

AFNetworking 3.0 #1037

@ikovalisko

This comment has been minimized.

Show comment
Hide comment
@ikovalisko

ikovalisko Nov 8, 2016

@dzenbot are you going to proceed with this PR?

ikovalisko commented Nov 8, 2016

@dzenbot are you going to proceed with this PR?

@beloso

This comment has been minimized.

Show comment
Hide comment
@beloso

beloso Feb 25, 2017

@dzenbot @kcharwood Is this still planned to be merged?

beloso commented Feb 25, 2017

@dzenbot @kcharwood Is this still planned to be merged?

@dzenbot

This comment has been minimized.

Show comment
Hide comment
@dzenbot

dzenbot Feb 25, 2017

Contributor

I'm just an IC here..

Contributor

dzenbot commented Feb 25, 2017

I'm just an IC here..

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Mar 23, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@4faefc2). Click here to learn what that means.
The diff coverage is 95.29%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #38   +/-   ##
=========================================
  Coverage          ?   94.86%           
=========================================
  Files             ?        4           
  Lines             ?      292           
  Branches          ?       13           
=========================================
  Hits              ?      277           
  Misses            ?       15           
  Partials          ?        0
Impacted Files Coverage Δ
AFNetworkActivityLogger/AFNetworkActivityLogger.m 95.45% <100%> (ø)
...orkActivityLogger/AFNetworkActivityConsoleLogger.h 100% <100%> (ø)
...orkActivityLogger/AFNetworkActivityConsoleLogger.m 77.77% <77.77%> (ø)
Tests/AFNetworkActivityLoggerTests.m 98.88% <98.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4faefc2...132fb6b. Read the comment docs.

codecov-io commented Mar 23, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@4faefc2). Click here to learn what that means.
The diff coverage is 95.29%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #38   +/-   ##
=========================================
  Coverage          ?   94.86%           
=========================================
  Files             ?        4           
  Lines             ?      292           
  Branches          ?       13           
=========================================
  Hits              ?      277           
  Misses            ?       15           
  Partials          ?        0
Impacted Files Coverage Δ
AFNetworkActivityLogger/AFNetworkActivityLogger.m 95.45% <100%> (ø)
...orkActivityLogger/AFNetworkActivityConsoleLogger.h 100% <100%> (ø)
...orkActivityLogger/AFNetworkActivityConsoleLogger.m 77.77% <77.77%> (ø)
Tests/AFNetworkActivityLoggerTests.m 98.88% <98.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4faefc2...132fb6b. Read the comment docs.

@SlaunchaMan SlaunchaMan merged commit 15a7678 into master Mar 23, 2018

4 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@SlaunchaMan SlaunchaMan deleted the 3_0_0 branch Mar 23, 2018

@dzenbot

This comment has been minimized.

Show comment
Hide comment
@dzenbot

dzenbot Apr 2, 2018

Contributor

Yay! Better late than never 💪

Contributor

dzenbot commented Apr 2, 2018

Yay! Better late than never 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment