Permalink
Commits on Aug 3, 2016
  1. @kcharwood

    Merge pull request #3565 from chenxin0123/cx

    Moved `[self didChangeValueForKey:@"currentState"]` into correct scope
    kcharwood committed on GitHub Aug 3, 2016
  2. @kcharwood

    Merge pull request #3604 from Starscream27/uiprogressview-completed-c…

    …rash
    
    Fixed an issue where registering a UIProgessView to a task that was a…
    kcharwood committed on GitHub Aug 3, 2016
  3. @kcharwood

    Merge pull request #3607 from wikimedia/bug/kvo-progress-removal

    Remove KVO of progress in favor of using the NSURLSession delegate APIs
    kcharwood committed on GitHub Aug 3, 2016
  4. @kcharwood

    Merge pull request #3612 from ethansinjin/master

    require app extension api only on watchOS
    kcharwood committed on GitHub Aug 3, 2016
Commits on Jul 15, 2016
  1. @ethansinjin
Commits on Jul 6, 2016
  1. @coreyfloyd

    Remove KVO of progress in favor of using the NSURLSession delegate APIs

    The impetus for this change was a bug related to:
    #3380
    
    Which points to an issue where AFURLSessionManager could get in a state where it does not inform the AFURLSessionManagerTaskDelegate to un-observe cancelled (or otherwise completed) tasks before they are deallocated.
    While the above issue is specific to background tasks/sessions, we have observed it on sessions with default configurations as well.
    
    Instead of debugging the KVO issues, I decided to replace the KVO code with in favor of the appropriate NSURLSession delegate methods.
    Running all unit tests shows that this approach appears to be working.
    
    The pull request that made this change (#3187) mentions that its goal was to remove the need for AFNetworking API consumers to use a KVO API for getting progress.
    This makes sense, but I was unable to see any reason why KVO was used internally for getting progress information rather than the NSURLSession Delegate methods.
    Because of this, It isn't clear to me what the historical reasons were/are for KVO being needed to satisfy the progress requirements of the AFNetworking API.
    
    With any luck, KVO is no longer needed and we can eliminate this class of crashes by eliminating KVO.
    coreyfloyd committed Jul 6, 2016
Commits on Jul 5, 2016
  1. Fixed an issue where registering a UIProgessView to a task that was a…

    …lready completed would crash with the following error:
    
    CRASH: Fatal exception: An instance ***** of class ******* was deallocated while key value observers were still registered with it.
    Mathieu Meylan committed Jul 5, 2016
Commits on Jun 11, 2016
  1. @chenxin0123

    move [self didChangeValueForKey:@"currentState"]; into if scope

    chenxin0123 committed Jun 11, 2016
Commits on Jun 6, 2016
  1. @kcharwood

    Merge pull request #3526 from alexbird/bugs/header-threading-crash

    Fixed crashes due to race conditions with NSMutableDictionary access in AFHTTPRequestSerialiser
    kcharwood committed Jun 6, 2016
  2. @kcharwood

    Merge pull request #3555 from hulizhen/master

    Update README.md
    kcharwood committed Jun 6, 2016
  3. @kcharwood

    Merge pull request #3504 from Coeur/patch-2

    documenting the workaround to uploadTaskWithRequest:fromFile: bug
    kcharwood committed Jun 6, 2016
Commits on Jun 4, 2016
  1. @hulizhen

    Update README.md

    Update the content of the section `Installation with CocoaPods` in `README.md`.
    hulizhen committed Jun 4, 2016
Commits on May 19, 2016
  1. @alexbird

    Fix for crashes due to dangerous NSMutableDictionary access in AFHTTP…

    …RequestSerialiser – Moved unit test to a better location.
    alexbird committed May 19, 2016
  2. @alexbird

    Fix for crashes due to dangerous NSMutableDictionary access in AFHTTP…

    …RequestSerialiser – Added unit test which reproduces the issue.
    
    NB: as the crash is caused by using a dictionary in a way that the runtime did not expect, it typically causes intermittent crashes which are almost always in unrelated areas of the app. This seems to be strongly related to deallocation of the values in the dictionary, but this may not be the only cause. As such, there is nothing to positively test for, the test succeeds if it doesn't EXC_BAD_ACCESS when cleaning up the @autoreleasepool at the end.
    alexbird committed May 19, 2016
Commits on May 12, 2016
  1. @Coeur

    documenting the workaround to uploadTaskWithRequest:fromFile: bug

    Coeur committed May 12, 2016
Commits on May 6, 2016
  1. @kcharwood

    Merge pull request #3490 from dchohfi/deprecating-method

    Added deprecated attribute to  `dataTaskWithRequest:completionHandler:`
    kcharwood committed May 6, 2016
  2. @kcharwood

    Merge pull request #3476 from ecaselles/ecaselles-update-methods-over…

    …ride-documentation
    
    Updates `AFHTTPSessionManager` documentation to reflect v3.x changes
    kcharwood committed May 6, 2016
  3. @kcharwood

    Merge pull request #3488 from gemmakbarlow/master

    Updated character
    kcharwood committed May 6, 2016
Commits on May 3, 2016
  1. @dchohfi

    Fixing unit tests for deprecated method

    dchohfi committed May 3, 2016
  2. @dchohfi
Commits on May 1, 2016
  1. @gemmakbarlow

    Updated character

    Updated to a different unicode dash (U+002D rather than U+2013) so that it is parsed correctly by markdown, when converting the CocoaPods Acknowledgements.markdown to HTML.
    gemmakbarlow committed May 1, 2016
Commits on Apr 28, 2016
  1. @ecaselles

    Updates documentation to reflect the new behaviour on GET, POST, etc.…

    … convenience methods.
    ecaselles committed Apr 28, 2016
Commits on Apr 11, 2016
  1. @kcharwood

    Merge pull request #3431 from 0xced/warnings

    Improved code base to generate fewer warnings when using strictor compiler settings
    kcharwood committed Apr 11, 2016
  2. @kcharwood

    Merge pull request #3432 from yulingtianxia/master

    remove unused `AFTaskStateChangedContext`
    kcharwood committed Apr 11, 2016
Commits on Apr 9, 2016
  1. @yulingtianxia

    remove unused `AFTaskStateChangedContext`

    `AFTaskStateChangedContext` is not used in AFN 3
    yulingtianxia committed Apr 9, 2016
Commits on Apr 8, 2016
  1. @0xced

    Enable more warnings

    0xced committed Apr 8, 2016
  2. @0xced

    Enable Treat Warnings as Errors

    0xced committed Apr 8, 2016
  3. @0xced

    Comment out unused static functions

    They were referenced in testPolicyWithCertificatePinningAllowsGoogleComServerTrustIncompleteChainWithRootCertificatePinnedAndValidDomainName which is now disabled.
    0xced committed Apr 8, 2016
  4. @0xced
  5. @0xced
Commits on Mar 31, 2016
  1. @kcharwood
  2. @kcharwood
  3. @kcharwood

    Merge pull request #3417 from AFNetworking/bug/ssl_pinning_disposition

    Reverted `NSURLSessionAuthChallengeDisposition` to `NSURLSessionAuthChallengeCancelAuthenticationChallenge` for SSL Pinning
    kcharwood committed Mar 31, 2016
  4. @kcharwood

    Merge pull request #3418 from AFNetworking/travis/update_xcode73

    Updated Test Suite to run on Xcode 7.3
    kcharwood committed Mar 31, 2016
  5. @kcharwood

    Reverted NSURLSession Challenge Disposition to be `NSURLSessionAuthCh…

    …allengeCancelAuthenticationChallenge` to allow for more determistic pinning results.
    
    - Updated test suite to check for new error code
    kcharwood committed Mar 31, 2016