Reachability did change notification should include payload in userInfo #489

Closed
tewha opened this Issue Aug 30, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@tewha
Contributor

tewha commented Aug 30, 2012

AFNetworkingReachabilityDidChangeNotification is sent with an object of 0 or 1, as if the 0 or 1 was sending the object. This is pretty nonstandard. Sending with a userInfo dictionary would improve this.

(I don't think there's any need to no longer send as if 0 or 1 was the object, just add a userInfo dictionary.)

mattt added a commit that referenced this issue Aug 31, 2012

@mattt

This comment has been minimized.

Show comment Hide comment
@mattt

mattt Aug 31, 2012

Contributor

My attempts to be lazy about defining constants caught up with me here. As of ec0240f, the notification fires without an object, and with a userInfo dictionary with the AFNetworkingReachabilityNotificationStatusItem key.

Contributor

mattt commented Aug 31, 2012

My attempts to be lazy about defining constants caught up with me here. As of ec0240f, the notification fires without an object, and with a userInfo dictionary with the AFNetworkingReachabilityNotificationStatusItem key.

@mattt mattt closed this Aug 31, 2012

egrim pushed a commit to egrim/AFNetworking that referenced this issue Sep 18, 2012

greghe pushed a commit to skillz/AFNetworking that referenced this issue Sep 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment