Remove unnecessary imports in UIImageView & UIWebView+AFNetworking headers #1861

Merged
merged 1 commit into from Mar 5, 2014

Conversation

Projects
None yet
2 participants
Contributor

jessedc commented Feb 27, 2014

This change brings the two headers mentioned inline with the other UIKit+AFN categories that do not import other AFN headers.

The imports are redundant if you are including AFNetworking.h. If you are not importing AFNetworking.h and wish to use the protocols and classes that are now forward declared, you'd need to import the particular headers yourself.

mattt added a commit that referenced this pull request Mar 5, 2014

Merge pull request #1861 from realestate-com-au/fix/unneeded-import
Remove unnecessary imports in UIImageView & UIWebView+AFNetworking headers

@mattt mattt merged commit 21e2280 into AFNetworking:master Mar 5, 2014

1 check passed

default The Travis CI build passed
Details
Contributor

mattt commented Mar 5, 2014

Thanks, @jessedc. You're right—unless there's any especially compelling reason, forward class & protocol declaration is preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment