hasSpaceAvailable become "false" and no failure blocks are called

[kcharwood]

I'm using AFNetworking (2.5.0) via Cocoapod in an iOS >7.0 application.
I need to download a binary file so i configured the outputStream property

AFHTTPRequestOperation *op = [self.operationManager GET:url
                                                 parameters:nil
                                                    success:^(AFHTTPRequestOperation *operation, id responseObject) {
                                                    } failure:^(AFHTTPRequestOperation *operation, NSError *error) {

            }];
op.outputStream = [NSOutputStream outputStreamToFileAtPath:tempPath append:YES];

90% of the times it works correctly, but in some case the line AFURLConnectionOperation.m@655 became false (i put a breakpoint) and the library enters in an endless loop and no failure blocks are called.

I put here the current implementation of the method

NSUInteger length = [data length];
    while (YES) {
        NSInteger totalNumberOfBytesWritten = 0;
        if ([self.outputStream hasSpaceAvailable]) {
            const uint8_t *dataBuffer = (uint8_t *)[data bytes];

            NSInteger numberOfBytesWritten = 0;
            while (totalNumberOfBytesWritten < (NSInteger)length) {
                numberOfBytesWritten = [self.outputStream write:&dataBuffer[(NSUInteger)totalNumberOfBytesWritten] maxLength:(length - (NSUInteger)totalNumberOfBytesWritten)];
                if (numberOfBytesWritten == -1) {
                    break;
                }

                totalNumberOfBytesWritten += numberOfBytesWritten;
            }

            break;
        } 

        if (self.outputStream.streamError) {
            [self.connection cancel];
            [self performSelector:@selector(connection:didFailWithError:) withObject:self.connection withObject:self.outputStream.streamError];
            return;
        }
    }

I think that if [self.outputStream hasSpaceAvailable] is false (for some reason) but there is not error on the outputStream the while() enters in an infinite loop.

[pdavid0]

+1 I'm having the issue too. The fix provided seems to do the trick. Any ETA for this fix to be integrated in the POD ?

[ignazioc]

it should be already in the current version because was fixed by mattt on 14 feb.

[pdavid0]

https://github.com/AFNetworking/AFNetworking/blob/2.5.4/AFNetworking/AFURLConnectionOperation.m#L670

it's not in 2.5.4

[nartex]

Still not fixed in 2.6.0
https://github.com/AFNetworking/AFNetworking/blob/2.6.0/AFNetworking/AFURLConnectionOperation.m#L658

[kcharwood]

Sorry I missed this issue. I'll get it updated soon. Thanks!

[nielsvroegindeweij]

I'm also having this same issue, about 10% of the times. In my tests, the problem seems to be related with low disk space on the device. Although I think this wasn't the case in all the tests. Maybe low disk space or low memory is the reason why NSOutputstream doesn't accept any more data?

I also used the provided fix, but I'm not completely sure about it(maybe I just don't understand the way this works):

• When NSOutputStream hasn't any space avalable the fix will immediately cancel the connection and return. Couldn't it be the NSOutputStream just didn't have enough time to write data to file or memory and need some loops to have space available again?
• When the outputstream hasn't space available and cancels the connection, most of the times the stream error property is not set. Although this will stop the endless looping, the failure or success method aren't called. As a result, the app will not be able to further handle this situation.

Maybe there is a way to recognize why hasSpaceAvailable stays false and provide this information to the failure block?

[kcharwood]

I'l get this one in today. Hopefully will cut a release before EOD

[kcharwood]

Not needed in the 3_0_0 branch since AFURLConnectionOperation has been removed.

[RbBtSn0w]

It's needs merge to 1.0 version