Deprecate the unused stringEncoding property of AFHTTPResponseSerializer #3751

Merged
merged 1 commit into from Oct 14, 2016

Projects

None yet

2 participants

@0xced
Collaborator
0xced commented Oct 13, 2016

The stringEncoding property is never used. It was probably inroduced by error in 9a40c0d. It was probably a copy/paste error as the same property also exists on AFHTTPRequestSerializer where it’s actually used.

@0xced 0xced Deprecate AFHTTPResponseSerializer.stringEncoding
The `stringEncoding` property is never used. It was probably inroduced by error in 9a40c0d. It was probably a copy/paste error as the same property also exists on `AFHTTPRequestSerializer` where it’s actually used.
33a403c
@0xced 0xced added this to the 3.2.0 milestone Oct 13, 2016
@skyline75489
Contributor

Is this sort of breaking backward compatibility ? If stick strictly to semver, this should probably be in 4.0.0.

@0xced
Collaborator
0xced commented Oct 14, 2016

I just marked the property as deprecated, so this is not breaking backward compatibility. Removing it would break compatibility and warrant a 4.0.0 version.

But even when introducing breaking changes, it’s always a good idea to deprecate and explain with a comment what the replacement is.

@skyline75489
Contributor
skyline75489 commented Oct 14, 2016 edited

Got it. Thanks for the explaination.

@0xced 0xced changed the title from Deprecate AFHTTPResponseSerializer.stringEncoding to Deprecate the unused stringEncoding property of AFHTTPResponseSerializer Oct 14, 2016
@0xced 0xced merged commit 4f3c694 into AFNetworking:master Oct 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@0xced 0xced deleted the 0xced:deprecate-stringEncoding branch Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment