New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CHANGELOG formatting #3915

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
4 participants
@joshfriend
Contributor

joshfriend commented Apr 5, 2017

  • Fix header formatting (requires space between # and header text)
  • Add missing links to release tags for some older versions
@SlaunchaMan

This comment has been minimized.

Show comment
Hide comment
@SlaunchaMan

SlaunchaMan Jul 13, 2017

Member

Thanks for the PR! Can you merge in master or rebase to get the tests passing?

Member

SlaunchaMan commented Jul 13, 2017

Thanks for the PR! Can you merge in master or rebase to get the tests passing?

@joshfriend

This comment has been minimized.

Show comment
Hide comment
@joshfriend

joshfriend Jul 13, 2017

Contributor

Done! Looks like the builds pass now

Contributor

joshfriend commented Jul 13, 2017

Done! Looks like the builds pass now

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jul 13, 2017

Codecov Report

Merging #3915 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3915   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files          45       45           
  Lines        5505     5505           
  Branches      439      439           
=======================================
  Hits         4787     4787           
  Misses        715      715           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5c955...e1ff8df. Read the comment docs.

codecov-io commented Jul 13, 2017

Codecov Report

Merging #3915 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3915   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files          45       45           
  Lines        5505     5505           
  Branches      439      439           
=======================================
  Hits         4787     4787           
  Misses        715      715           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5c955...e1ff8df. Read the comment docs.

@SlaunchaMan

This comment has been minimized.

Show comment
Hide comment
@SlaunchaMan

SlaunchaMan Jul 13, 2017

Member

@jshier This should be good to merge!

Member

SlaunchaMan commented Jul 13, 2017

@jshier This should be good to merge!

@jshier jshier merged commit e6d9756 into AFNetworking:master Jul 13, 2017

3 checks passed

codecov/patch Coverage not affected when comparing ec5c955...e1ff8df
Details
codecov/project 86.95% remains the same compared to ec5c955
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joshfriend joshfriend deleted the joshfriend:changelog-format-fix branch Jul 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment