New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests pass again #3993

Merged
merged 2 commits into from Jul 13, 2017

Conversation

Projects
None yet
3 participants
@SlaunchaMan
Member

SlaunchaMan commented Jul 13, 2017

This PR makes the security policy tests pass again. Some of the tests have been removed as they are no longer valid; #3979 fixes this by copying in Alamofire’s test suite (and certificates).

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jul 13, 2017

Codecov Report

Merging #3993 into master will decrease coverage by 0.5%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3993      +/-   ##
==========================================
- Coverage   87.44%   86.93%   -0.51%     
==========================================
  Files          45       45              
  Lines        6227     5505     -722     
  Branches      416      439      +23     
==========================================
- Hits         5445     4786     -659     
+ Misses        779      716      -63     
  Partials        3        3
Impacted Files Coverage Δ
Tests/Tests/AFSecurityPolicyTests.m 100% <100%> (ø) ⬆️
UIKit+AFNetworking/UIButton+AFNetworking.m 77.14% <0%> (-4.15%) ⬇️
UIKit+AFNetworking/UIRefreshControl+AFNetworking.m 70.73% <0%> (-3.69%) ⬇️
AFNetworking/AFHTTPSessionManager.m 88.31% <0%> (-2.79%) ⬇️
UIKit+AFNetworking/UIWebView+AFNetworking.m 76.92% <0%> (-1.65%) ⬇️
AFNetworking/AFURLRequestSerialization.m 70.64% <0%> (-1.63%) ⬇️
AFNetworking/AFURLResponseSerialization.m 85.5% <0%> (-1.37%) ⬇️
AFNetworking/AFURLSessionManager.m 69.38% <0%> (-1.29%) ⬇️
AFNetworking/AFNetworkReachabilityManager.m 71.9% <0%> (-1.29%) ⬇️
AFNetworking/AFSecurityPolicy.m 93.82% <0%> (-1.12%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f3c694...e05a7a6. Read the comment docs.

codecov-io commented Jul 13, 2017

Codecov Report

Merging #3993 into master will decrease coverage by 0.5%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3993      +/-   ##
==========================================
- Coverage   87.44%   86.93%   -0.51%     
==========================================
  Files          45       45              
  Lines        6227     5505     -722     
  Branches      416      439      +23     
==========================================
- Hits         5445     4786     -659     
+ Misses        779      716      -63     
  Partials        3        3
Impacted Files Coverage Δ
Tests/Tests/AFSecurityPolicyTests.m 100% <100%> (ø) ⬆️
UIKit+AFNetworking/UIButton+AFNetworking.m 77.14% <0%> (-4.15%) ⬇️
UIKit+AFNetworking/UIRefreshControl+AFNetworking.m 70.73% <0%> (-3.69%) ⬇️
AFNetworking/AFHTTPSessionManager.m 88.31% <0%> (-2.79%) ⬇️
UIKit+AFNetworking/UIWebView+AFNetworking.m 76.92% <0%> (-1.65%) ⬇️
AFNetworking/AFURLRequestSerialization.m 70.64% <0%> (-1.63%) ⬇️
AFNetworking/AFURLResponseSerialization.m 85.5% <0%> (-1.37%) ⬇️
AFNetworking/AFURLSessionManager.m 69.38% <0%> (-1.29%) ⬇️
AFNetworking/AFNetworkReachabilityManager.m 71.9% <0%> (-1.29%) ⬇️
AFNetworking/AFSecurityPolicy.m 93.82% <0%> (-1.12%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f3c694...e05a7a6. Read the comment docs.

@jshier jshier merged commit ec5c955 into AFNetworking:master Jul 13, 2017

3 checks passed

codecov/patch 100% of diff hit (target 87.44%)
Details
codecov/project Absolute coverage decreased by -0.5% but relative coverage increased by +12.55% compared to 4f3c694
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SlaunchaMan SlaunchaMan deleted the SlaunchaMan:update-security-policy-test-certificates branch Jul 13, 2017

TheDom added a commit to TheDom/AFNetworking that referenced this pull request Jul 13, 2017

Make tests pass again (#3993)
* Make tests pass again

* Fix macOS builds in Fastlane.

jshier added a commit that referenced this pull request Jul 22, 2017

Allow return value of HTTP redirection block to be NULL (#3975)
* Allow return value of HTTP redirection block to be NULL

* Make tests pass again (#3993)

* Make tests pass again

* Fix macOS builds in Fastlane.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment