New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix space used in Objective-C method (coding style) #4002

Merged
merged 2 commits into from Jun 8, 2018

Conversation

Projects
None yet
4 participants
@LeeHongHwa
Contributor

LeeHongHwa commented Jul 19, 2017

  1. apple documented coding guidelines, which uses (space after -)
  2. fix asterisk location in method declaration

https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/NamingBasics.html#//apple_ref/doc/uid/20001281-BBCHBFAH

@codecov-io

This comment has been minimized.

codecov-io commented Jul 19, 2017

Codecov Report

Merging #4002 into master will decrease coverage by 4.45%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4002      +/-   ##
=========================================
- Coverage   86.95%   82.5%   -4.46%     
=========================================
  Files          45      45              
  Lines        5505    5270     -235     
  Branches      439     439              
=========================================
- Hits         4787    4348     -439     
+ Misses        715     682      -33     
- Partials        3     240     +237
Impacted Files Coverage Δ
Tests/Tests/AFURLSessionManagerTests.m 81.49% <0%> (ø) ⬆️
UIKit+AFNetworking/AFImageDownloader.m 91.42% <100%> (-6.11%) ⬇️
UIKit+AFNetworking/AFAutoPurgingImageCache.m 93.39% <100%> (-2.91%) ⬇️
UIKit+AFNetworking/UIWebView+AFNetworking.m 64.4% <100%> (-12.52%) ⬇️
...FNetworking/UIActivityIndicatorView+AFNetworking.m 83.33% <0%> (-14.29%) ⬇️
AFNetworking/AFURLResponseSerialization.m 71.97% <0%> (-13.53%) ⬇️
UIKit+AFNetworking/UIRefreshControl+AFNetworking.m 58.53% <0%> (-12.2%) ⬇️
AFNetworking/AFURLRequestSerialization.m 59.9% <0%> (-10.74%) ⬇️
AFNetworking/AFURLSessionManager.m 59.89% <0%> (-9.5%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6d9756...27c8195. Read the comment docs.

@SlaunchaMan SlaunchaMan merged commit b158887 into AFNetworking:master Jun 8, 2018

3 checks passed

codecov/patch 90.9% of diff hit (target 86.95%)
Details
codecov/project Absolute coverage decreased by -4.45% but relative coverage increased by +3.95% compared to e6d9756
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SlaunchaMan SlaunchaMan added this to the 3.3.0 milestone Jun 8, 2018

@SlaunchaMan SlaunchaMan added the fixed label Jun 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment