New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CLANG_ENABLE_CODE_COVERAGE flag so release can be made #4081

Merged
merged 3 commits into from Oct 2, 2018

Conversation

Projects
None yet
3 participants
@MapaX

MapaX commented Oct 12, 2017

Submissions to iTunes Connect (built with Xcode 9) are failing in processing with the following message:

Invalid Bundle - Disallowed LLVM instrumentation. Do not submit apps with LLVM profiling instrumentation or coverage collection enabled. Turn off LLVM profiling or code coverage, rebuild your app and resubmit the app.

Part of the problem is fixed in Carthage, but the Code coverage needs to be set NO in project. Atleast now.
Carthage/Carthage#2056

This Pull request will update the flags so you can build and release your app.

https://developer.apple.com/library/content/qa/qa1964/_index.html

@SlaunchaMan

This comment has been minimized.

Show comment
Hide comment
@SlaunchaMan

SlaunchaMan Jun 8, 2018

Member

Looks like this PR also has some unrelated changes that are causing a conflict. @MapaX, can you merge in master?

Member

SlaunchaMan commented Jun 8, 2018

Looks like this PR also has some unrelated changes that are causing a conflict. @MapaX, can you merge in master?

@SlaunchaMan SlaunchaMan added this to the 3.3.0 milestone Jul 13, 2018

@Kaspik

This comment has been minimized.

Show comment
Hide comment
@Kaspik

Kaspik Sep 28, 2018

Contributor

Can be merged for release 3.3.0?

Contributor

Kaspik commented Sep 28, 2018

Can be merged for release 3.3.0?

@SlaunchaMan SlaunchaMan merged commit 27608c9 into AFNetworking:master Oct 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment