Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed memory leak issues #4196

Merged
merged 6 commits into from Jan 5, 2020
Merged

Fixed memory leak issues #4196

merged 6 commits into from Jan 5, 2020

Conversation

@svoit
Copy link
Contributor

svoit commented Apr 9, 2018

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 9, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@5cf601c). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4196   +/-   ##
=========================================
  Coverage          ?   79.68%           
=========================================
  Files             ?       15           
  Lines             ?     2825           
  Branches          ?        0           
=========================================
  Hits              ?     2251           
  Misses            ?      574           
  Partials          ?        0
Impacted Files Coverage Δ
AFNetworking/AFURLSessionManager.m 69.52% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf601c...47d0498. Read the comment docs.

@Kaspik

This comment has been minimized.

Copy link
Contributor

Kaspik commented Sep 28, 2018

Needs merge of master to fix conflicts as some of these issues have been fixed.

* master: (61 commits)
  Update Travis config for Xcode 10.
  Add test for object posting notification
  update README.md, the old "Foundation URL Loading System" link is 404
  Change test name to correct one
  Change default teardown methods to tests
  Update tests to use new API
  Update PR feedback, add more tests
  Add test
  remove temporary method that could be doing nothing
  Update HTTPBin certificates.
  Chinese CONTRIBUTING.md translate
  Delete CONTRIBUTING_CH.md
  Chinese Contributing.md translate
  rollback method 'AFPostReachabilityStatusChange'
  Use AFNetworkReachabilityManager to compare  consistency of notification posts and gets, instead of SCNetworkReachabilityRef. And test case reference.
  Remove test that is nilling session manually as it's not possible anymore to not have valid session (correctly)
  Add tests for  verifing reachability manager consistence  for notification posting and getting
  Specify Xcode 9.4 in Travis file.
  Update AFImageDownloader.m
  Add an ability that notification-observer know which reachability its belong
  ...

# Conflicts:
#	AFNetworking/AFURLSessionManager.m
@svoit

This comment has been minimized.

Copy link
Contributor Author

svoit commented Oct 8, 2018

@Kaspik It is done.
@SlaunchaMan Could this pull request be merged?

* master:
  Update HTTPBin certificates
  Update HTTPBin certificates, good through December 2018.
  Removed redundant switch case
  Code cleaning
@jshier

This comment has been minimized.

Copy link
Contributor

jshier commented Oct 21, 2019

The strong / weak dance isn't necessary except in the NSNotificationCenter case. If you can limit the changes to that code, we can get this merged.

svoit added 3 commits Nov 17, 2019
* master:
  Updated SSL Pinning Test Assets (#4463)
  Fix typeof (#3912)
  adding tvOS user agent information (#4014)
  Update code coverage settings (#4201)
  Fix CHANGELOG Styling (#4460)
  Fix NSSecureCoding (#4409)
  Fix podspec as pod version supports iOS 8+ but podspec says iOS 7+
@svoit svoit closed this Dec 21, 2019
@svoit svoit reopened this Dec 21, 2019
@jshier
jshier approved these changes Jan 5, 2020
Copy link
Contributor

jshier left a comment

👍 Thanks, looks good!

@jshier jshier merged commit 0fba527 into AFNetworking:master Jan 5, 2020
0 of 3 checks passed
0 of 3 checks passed
codecov/patch CI failed.
Details
codecov/project CI failed.
Details
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.