New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleaning #4200

merged 3 commits into from Feb 9, 2019


None yet
3 participants
Copy link

svoit commented Apr 10, 2018

Formatting and removing code redundancies


This comment has been minimized.

Copy link

codecov-io commented Apr 10, 2018

Codecov Report

Merging #4200 into master will decrease coverage by 0.43%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4200      +/-   ##
- Coverage   88.05%   87.61%   -0.44%     
  Files          46       46              
  Lines        5992     5734     -258     
- Hits         5276     5024     -252     
+ Misses        716      710       -6
Impacted Files Coverage Δ
AFNetworking/AFSecurityPolicy.m 93.82% <0%> (-1.13%) ⬇️
UIKit+AFNetworking/UIImageView+AFNetworking.m 97.01% <100%> (ø) ⬆️
UIKit+AFNetworking/AFAutoPurgingImageCache.m 96.42% <100%> (ø) ⬆️
AFNetworking/AFURLResponseSerialization.m 88.82% <100%> (-0.53%) ⬇️
Tests/Tests/AFImageDownloaderTests.m 98.51% <100%> (+0.49%) ⬆️
UIKit+AFNetworking/UIButton+AFNetworking.m 77.85% <100%> (-4.29%) ⬇️
Tests/Tests/AFAutoPurgingImageCacheTests.m 99.34% <100%> (ø) ⬆️
AFNetworking/AFURLSessionManager.m 71.21% <50%> (+0.79%) ⬆️
AFNetworking/AFHTTPSessionManager.m 89.03% <0%> (-1.72%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27608c9...d6db830. Read the comment docs.

svoit added some commits Apr 11, 2018

Merge branch 'master' into code_cleaning
* master: (61 commits)
  Update Travis config for Xcode 10.
  Add test for object posting notification
  update, the old "Foundation URL Loading System" link is 404
  Change test name to correct one
  Change default teardown methods to tests
  Update tests to use new API
  Update PR feedback, add more tests
  Add test
  remove temporary method that could be doing nothing
  Update HTTPBin certificates.
  Chinese translate
  Chinese translate
  rollback method 'AFPostReachabilityStatusChange'
  Use AFNetworkReachabilityManager to compare  consistency of notification posts and gets, instead of SCNetworkReachabilityRef. And test case reference.
  Remove test that is nilling session manually as it's not possible anymore to not have valid session (correctly)
  Add tests for  verifing reachability manager consistence  for notification posting and getting
  Specify Xcode 9.4 in Travis file.
  Update AFImageDownloader.m
  Add an ability that notification-observer know which reachability its belong

This comment has been minimized.

Copy link
Contributor Author

svoit commented Oct 29, 2018

@SlaunchaMan Could this pull request be merged?


This comment has been minimized.

Copy link

SlaunchaMan commented Feb 9, 2019


@SlaunchaMan SlaunchaMan merged commit ee95094 into AFNetworking:master Feb 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment