New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to pull 420 #422

Merged
merged 3 commits into from Jul 24, 2012

Conversation

Projects
None yet
2 participants
@tewha
Contributor

tewha commented Jul 23, 2012

Per Apple's Platform Dependencies in String Programming Guide, casting NSInteger to long before using %lu.

https://developer.apple.com/library/ios/#documentation/Cocoa/Conceptual/Strings/Articles/formatSpecifiers.html#//apple_ref/doc/uid/TP40004265-SW5

tewha added some commits Jul 23, 2012

Very minor security fix.
`informativeTextWithFormat` interprets its string as a format. `[error localizedDescription]` could contain string formatting specifiers.

Fixes to use @"%@", [error localizedDescription] instead.

Spotted via compiler warning.
@tewha

This comment has been minimized.

Contributor

tewha commented Jul 23, 2012

Apparently I somehow managed to add a minor security fix suggested by the compiler after I created this pull request. Not sure how. It's still safe, and I'll make sure not to do anything else. :)

@mattt

This comment has been minimized.

Contributor

mattt commented Jul 23, 2012

Thanks for following up on this. String format specifiers are kinda the worst—no matter how pedantic I try to get, Xcode isn't impressed.

That security fix makes sense, too. Thanks for adding that in.

@mattt mattt closed this Jul 23, 2012

@tewha

This comment has been minimized.

Contributor

tewha commented Jul 23, 2012

Mattt, did you apply this and it's just taking a while? I don't see it in the commit log.

@mattt mattt reopened this Jul 24, 2012

mattt added a commit that referenced this pull request Jul 24, 2012

@mattt mattt merged commit 877333a into AFNetworking:master Jul 24, 2012

@mattt

This comment has been minimized.

Contributor

mattt commented Jul 24, 2012

Heh, I was wondering where that went! Done and done.

egrim pushed a commit to egrim/AFNetworking that referenced this pull request Sep 18, 2012

greghe pushed a commit to skillz/AFNetworking that referenced this pull request Sep 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment