Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix podspec #trivial #important #4365

Merged
merged 1 commit into from Mar 1, 2019

Conversation

Projects
None yet
3 participants
@Kaspik
Copy link
Contributor

Kaspik commented Mar 1, 2019

  • Fix podspec as library version supports iOS 8+ (in project) but podspec says iOS 7+

Note: We should release new version with this fix I think.

@Kaspik Kaspik changed the title Fix podspec Fix podspec #trivial #important Mar 1, 2019

@Kaspik

This comment has been minimized.

Copy link
Contributor Author

Kaspik commented Mar 1, 2019

@SlaunchaMan I hope I'm not wrong with this issue but if I'm not it could potentially cause some issues?

@SlaunchaMan SlaunchaMan added this to the 3.3.0 milestone Mar 1, 2019

@SlaunchaMan

This comment has been minimized.

Copy link
Member

SlaunchaMan commented Mar 1, 2019

Yep, I had planned this for 3.3.0 anyway—we don’t support below iOS 8 and neither do modern versions of Xcode.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 1, 2019

Codecov Report

Merging #4365 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4365   +/-   ##
=======================================
  Coverage   88.44%   88.44%           
=======================================
  Files          36       36           
  Lines        5650     5650           
=======================================
  Hits         4997     4997           
  Misses        653      653

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee95094...b3c4a78. Read the comment docs.

@SlaunchaMan SlaunchaMan merged commit 685e31a into AFNetworking:master Mar 1, 2019

3 checks passed

codecov/patch Coverage not affected when comparing ee95094...b3c4a78
Details
codecov/project 88.44% remains the same compared to ee95094
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.