Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis CI build #4472

Merged
merged 12 commits into from Jan 4, 2020
Merged

Fix travis CI build #4472

merged 12 commits into from Jan 4, 2020

Conversation

@bofeizhu
Copy link
Contributor

bofeizhu commented Nov 7, 2019

Remove outdated envs. Unblock #4439.

bofeizhu added 7 commits Nov 7, 2019
nit
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 7, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@5cf601c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4472   +/-   ##
=========================================
  Coverage          ?   79.66%           
=========================================
  Files             ?       15           
  Lines             ?     2827           
  Branches          ?        0           
=========================================
  Hits              ?     2252           
  Misses            ?      575           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf601c...cfd1250. Read the comment docs.

@bofeizhu

This comment has been minimized.

Copy link
Contributor Author

bofeizhu commented Nov 7, 2019

@jshier ✗ testProgressIsSet, Asynchronous wait failed: Exceeded timeout of 20 seconds, with unfulfilled expectations: "Expect value of 'fractionCompleted' of <NSProgress: 0x60e000076e80> : Parent: 0x0 (portion: 0) / Fraction completed: 0.0000 / Completed: 0 of -1 to be '1'". This test fails randomly. Should we remove it?

All the other CI issues should be fixed by this PR.

bofeizhu added 2 commits Nov 7, 2019
@bofeizhu

This comment has been minimized.

Copy link
Contributor Author

bofeizhu commented Nov 8, 2019

I added Xcode 11 and remove both Xcode 8 & 7. Lmk if you think I should add Xcode 8 back.

bofeizhu added 2 commits Nov 9, 2019
@bofeizhu

This comment has been minimized.

Copy link
Contributor Author

bofeizhu commented Nov 10, 2019

@jshier I got all the CI passing. Could we merge this?

@bofeizhu bofeizhu mentioned this pull request Nov 12, 2019
@kinarobin

This comment has been minimized.

Copy link

kinarobin commented Nov 25, 2019

LGTM!

@hotbott

This comment has been minimized.

Copy link

hotbott commented Nov 25, 2019

Also fixes Carthage compilation issues on Xcode 11.

@hotbott

This comment has been minimized.

Copy link

hotbott commented Nov 26, 2019

Any plans to merge that PR soon? As mentioned, the framework is not working with Carthage right now!

@bofeizhu

This comment has been minimized.

Copy link
Contributor Author

bofeizhu commented Nov 26, 2019

@hotbott Unfortunately, I'm not a maintainer for this repo 😞. I can't merge this PR by myself.

@hotbott

This comment has been minimized.

Copy link

hotbott commented Nov 27, 2019

@jshier Please review && release

@tmm1

This comment has been minimized.

Copy link

tmm1 commented Dec 23, 2019

Ping

@bofeizhu

This comment has been minimized.

Copy link
Contributor Author

bofeizhu commented Dec 23, 2019

@jshier @kylef, @cnoon, @conradev, @SlaunchaMan

https://developer.apple.com/news/?id=12232019b

Updating Apps that Use Web Views
December 23, 2019
If your app still embeds web content using the deprecated UIWebView API, we strongly encourage you to update to WKWebView as soon as possible for improved security and reliability. WKWebView ensures that compromised web content doesn’t affect the rest of an app by limiting web processing to the app’s web view. And it’s supported in iOS and macOS, and by Mac Catalyst.
The App Store will no longer accept new apps using UIWebView as of April 2020 and app updates using UIWebView as of December 2020.

@jshier

This comment has been minimized.

Copy link
Contributor

jshier commented Jan 4, 2020

@bofeizhu Good work here! However, we can't yet drop testing support for older OS versions, so we need to bring the older versions back. I believe AFNetworking still technically supports back to Xcode 7, but I think Xcode 8.3 is as far back as we need to go right now. We don't need a huge amount of device coverage, just one per version / platform should be enough. So the following Travis images can be used:

  • xcode11.3
  • xcode10.3
  • xcode9.4
  • xcode8.3

If the 8.3 or 9.4 environments are too old to support the Ruby environment we need, that's fine, we can do without, but I'd like to make sure.

Finally, feel free to remove that UIWebView test that was commented out.

@jshier

This comment has been minimized.

Copy link
Contributor

jshier commented Jan 4, 2020

@bofeizhu Actually, I'm going to merge this as is to get Travis working. But I'd appreciate an additional PR that adds the older versions back.

@jshier jshier merged commit 4743faa into AFNetworking:master Jan 4, 2020
3 checks passed
3 checks passed
codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bofeizhu

This comment has been minimized.

Copy link
Contributor Author

bofeizhu commented Jan 4, 2020

@jshier Sure, I can submit an additional PR next week. Thank you!

@bofeizhu bofeizhu deleted the bofeizhu:patch-1 branch Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.