Some minor stuff #902

Merged
merged 2 commits into from Apr 9, 2013

Conversation

Projects
None yet
2 participants
@OliverLetterer
Contributor

OliverLetterer commented Apr 8, 2013

By taking a look over the current SSL pinning feature, I figured than

  • Security.framework doesn't define noErr but rather errSecSuccess as OSStatus and it's good practice to use the frameworks defined status codes in case they might eventually change in the future.
  • +[NSURLConnectionOperation pinnedPublicKeys] was using NSCParameterAssert instead of NSParameterAssert which I think is wrong here because its an objc method implementation.

mattt added a commit that referenced this pull request Apr 9, 2013

@mattt mattt merged commit 0d49f73 into AFNetworking:master Apr 9, 2013

@mattt

This comment has been minimized.

Show comment Hide comment
@mattt

mattt Apr 9, 2013

Contributor

Pedantic bugfixes are the best. You're awesome. Thanks, @OliverLetterer!

Contributor

mattt commented Apr 9, 2013

Pedantic bugfixes are the best. You're awesome. Thanks, @OliverLetterer!

greghe pushed a commit to skillz/AFNetworking that referenced this pull request Sep 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment