From 891a24a0581bf1629135f5b590ac12f015ce2584 Mon Sep 17 00:00:00 2001 From: Aman Gupta Date: Thu, 13 Mar 2025 19:01:10 +0000 Subject: [PATCH 1/3] Adding a parameter=lora_input_adapters_path, to start the server with path if the path is available. Else None. --- jetstream/core/server_lib.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/jetstream/core/server_lib.py b/jetstream/core/server_lib.py index 5e64b8f5..8960f97f 100644 --- a/jetstream/core/server_lib.py +++ b/jetstream/core/server_lib.py @@ -187,6 +187,7 @@ def run( jax_profiler_port: int = 9999, enable_model_warmup: bool = False, multi_sampling: bool = False, + lora_input_adapters_path: str = None, ) -> JetStreamServer: """Runs a server with a specified config. @@ -203,6 +204,7 @@ def run( jax_profiler_port: The port JAX profiler server (default to 9999). enable_model_warmup: The flag to enable model server warmup. multi_sampling: The flag to enable multi-sampling. + lora_input_adapters_path: Path to define the location of all lora adapters. Returns: JetStreamServer that wraps the grpc server and orchestrator driver. From 1fd9d25d5bfb959d30c70c9b951a43f63d891581 Mon Sep 17 00:00:00 2001 From: Aman Gupta Date: Thu, 13 Mar 2025 19:12:53 +0000 Subject: [PATCH 2/3] Fixing Lint error. --- jetstream/core/server_lib.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jetstream/core/server_lib.py b/jetstream/core/server_lib.py index 8960f97f..fb1fdfb2 100644 --- a/jetstream/core/server_lib.py +++ b/jetstream/core/server_lib.py @@ -187,7 +187,7 @@ def run( jax_profiler_port: int = 9999, enable_model_warmup: bool = False, multi_sampling: bool = False, - lora_input_adapters_path: str = None, + lora_input_adapters_path: str | None = None, ) -> JetStreamServer: """Runs a server with a specified config. From 92cdadcd51c6f0161f59a623040d70893cfaf599 Mon Sep 17 00:00:00 2001 From: Aman Gupta Date: Thu, 13 Mar 2025 19:27:40 +0000 Subject: [PATCH 3/3] Fixed Linter error. --- jetstream/core/server_lib.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/jetstream/core/server_lib.py b/jetstream/core/server_lib.py index fb1fdfb2..bd68257e 100644 --- a/jetstream/core/server_lib.py +++ b/jetstream/core/server_lib.py @@ -209,6 +209,11 @@ def run( Returns: JetStreamServer that wraps the grpc server and orchestrator driver. """ + # TODO: Deleting the lora_input_adapters_path for now. + # Planning to use it in next big PR. Currently accomodating it + # to fix the params mismatch between maxText and JetStream + del lora_input_adapters_path + server_start_time = time.time() logging.info("Kicking off gRPC server.") # Setup Prometheus server