From 8f95a837e490598ac7a8151045dd758e307f1211 Mon Sep 17 00:00:00 2001 From: Brendan Slabe Date: Mon, 3 Jun 2024 23:09:32 +0000 Subject: [PATCH 1/2] Metrics bug: server_lib should be config_lib --- run_server.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/run_server.py b/run_server.py index f85bdbb4..4f9057c4 100644 --- a/run_server.py +++ b/run_server.py @@ -20,7 +20,7 @@ import jetstream_pt from absl import app, flags from jetstream.core import server_lib -from jetstream.core.config_lib import ServerConfig +from jetstream.core.config_lib import ServerConfig, MetricsServerConfig from jetstream_pt.config import FLAGS, create_engine_from_config_flags flags.DEFINE_integer("port", 9000, "port to listen on") @@ -49,9 +49,9 @@ def main(argv: Sequence[str]): ) print(f"server_config: {server_config}") - metrics_server_config: server_lib.MetricsServerConfig | None = None + metrics_server_config: MetricsServerConfig | None = None if FLAGS.prometheus_port != 0: - metrics_server_config = server_lib.MetricsServerConfig( + metrics_server_config = MetricsServerConfig( port=FLAGS.prometheus_port ) From 239b0ab095bbf70d0a9e19071bf24f652331b192 Mon Sep 17 00:00:00 2001 From: Brendan Slabe Date: Tue, 4 Jun 2024 02:58:23 +0000 Subject: [PATCH 2/2] format --- run_server.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/run_server.py b/run_server.py index 4f9057c4..1ed199a3 100644 --- a/run_server.py +++ b/run_server.py @@ -51,9 +51,7 @@ def main(argv: Sequence[str]): metrics_server_config: MetricsServerConfig | None = None if FLAGS.prometheus_port != 0: - metrics_server_config = MetricsServerConfig( - port=FLAGS.prometheus_port - ) + metrics_server_config = MetricsServerConfig(port=FLAGS.prometheus_port) # We separate credential from run so that we can unit test it with local credentials. # We would like to add grpc credentials for OSS.