From 21122e9a547b98d3715e5959288eca886837503e Mon Sep 17 00:00:00 2001 From: Brendan Slabe Date: Wed, 22 May 2024 21:26:57 +0000 Subject: [PATCH 1/2] first commit --- run_server.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/run_server.py b/run_server.py index cc462c4b..bc0dd033 100644 --- a/run_server.py +++ b/run_server.py @@ -30,6 +30,7 @@ "InterleavedCPUTestServer", "available servers", ) +flags.DEFINE_integer("prometheus_port", 0, "") # pylint: disable-next=all @@ -48,6 +49,12 @@ def main(argv: Sequence[str]): ) print(f"server_config: {server_config}") + metrics_server_config : server_lib.MetricsServerConfig | None = None + if FLAGS.prometheus_port != 0: + metrics_server_config = server_lib.MetricsServerConfig( + port=FLAGS.prometheus_port + ) + # We separate credential from run so that we can unit test it with local credentials. # We would like to add grpc credentials for OSS. jetstream_server = server_lib.run( @@ -55,6 +62,7 @@ def main(argv: Sequence[str]): port=FLAGS.port, config=server_config, devices=devices, + metrics_server_config=metrics_server_config ) print("Started jetstream_server....") jetstream_server.wait_for_termination() From c548a30dcca028617202b7086f3cfb0687e85690 Mon Sep 17 00:00:00 2001 From: Brendan Slabe Date: Thu, 23 May 2024 17:28:01 +0000 Subject: [PATCH 2/2] reformat --- run_server.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/run_server.py b/run_server.py index bc0dd033..f85bdbb4 100644 --- a/run_server.py +++ b/run_server.py @@ -49,11 +49,11 @@ def main(argv: Sequence[str]): ) print(f"server_config: {server_config}") - metrics_server_config : server_lib.MetricsServerConfig | None = None + metrics_server_config: server_lib.MetricsServerConfig | None = None if FLAGS.prometheus_port != 0: metrics_server_config = server_lib.MetricsServerConfig( port=FLAGS.prometheus_port - ) + ) # We separate credential from run so that we can unit test it with local credentials. # We would like to add grpc credentials for OSS. @@ -62,7 +62,7 @@ def main(argv: Sequence[str]): port=FLAGS.port, config=server_config, devices=devices, - metrics_server_config=metrics_server_config + metrics_server_config=metrics_server_config, ) print("Started jetstream_server....") jetstream_server.wait_for_termination()