Skip to content

Revert "Fix bug in assigning block_q_dq when block sizes are not specified" #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2025
Merged

Revert "Fix bug in assigning block_q_dq when block sizes are not specified" #287

merged 1 commit into from
Nov 24, 2025

Conversation

@coolkp
Copy link
Collaborator

@coolkp coolkp commented Nov 24, 2025

Reverts #282

@github-actions
Copy link

github-actions bot commented Nov 24, 2025

e2e testgrid: https://8bcf50593faf4ea38060e236169827e5-dot-us-central1.composer.googleusercontent.com/dags/maxdiffusion_tpu_e2e/grid

@coolkp coolkp merged commit 503e9d6 into main Nov 24, 2025
3 of 4 checks passed
eltsai pushed a commit that referenced this pull request Dec 2, 2025
Reapply cross self attention switch and attention bug fixes
b4f9507 
This commit reapplies both:
- Cross self attention switch (#251) (#288)
- Attention bug fixes, tokamax splash defaulting logic (#282) (#287)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eltsai eltsai eltsai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coolkp @eltsai